You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/07/21 14:26:03 UTC

[GitHub] [skywalking] qxo opened a new pull request #3136: Add a ability for checker whether the span is in asyncMode

qxo opened a new pull request #3136: Add a ability for checker whether the span is in asyncMode
URL: https://github.com/apache/skywalking/pull/3136
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   Add a ability for checker whether the span is in asyncMode
   so on the plugin we write code as below:
   ```
   if (parentSpan.isInAsyncMode()){
       parentSpan.asyncFinish();
   }
   ```
   do asyncFinish only if inAsyncMode=true
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services