You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by benstopford <gi...@git.apache.org> on 2016/10/03 12:43:26 UTC

[GitHub] kafka pull request #1950: MINOR: Add unit tests to the ReassignPartitionsCom...

GitHub user benstopford opened a pull request:

    https://github.com/apache/kafka/pull/1950

    MINOR: Add unit tests to the ReassignPartitionsCommand 

    Adds a bunch of tests to unit tests to the assignment command. 
    Moves the Rack aware test into its own class as it makes use of ZooKeeperTestHarness and slows everything else down. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benstopford/kafka os-rebalance-extra-unit-testing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1950
    
----
commit b8fcac7b6f0b69faf7f5ad0584d792f8e023f3c7
Author: Ben Stopford <be...@gmail.com>
Date:   2016-10-01T07:13:58Z

    Speed build by making ReassignPartitionsCommandTest a unit test by moving rack aware test method (which uses ZK) into its own class.

commit 8dc9d7b0bfa9e6e2cd5f16339fe7dd49e5400589
Author: Ben Stopford <be...@gmail.com>
Date:   2016-10-03T12:24:45Z

    Add tests to the reassignment command

commit a5e213ce5791c8d1a9599508e407c01512ae9bf2
Author: Ben Stopford <be...@gmail.com>
Date:   2016-10-03T12:39:23Z

    reformat license

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1950: MINOR: Add unit tests to the ReassignPartitionsCom...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1950


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---