You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org> on 2026/04/14 15:26:44 UTC
[PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Aggarwal-Raghav opened a new pull request, #481:
URL: https://github.com/apache/tez/pull/481
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4245895072
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 11s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 57s | | master passed |
| +1 :green_heart: | compile | 1m 29s | | master passed |
| +1 :green_heart: | checkstyle | 1m 4s | | master passed |
| +1 :green_heart: | javadoc | 1m 12s | | master passed |
| +0 :ok: | spotbugs | 0m 59s | | tez-dag in master has 749 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 54s | | root in master has 1935 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 28s | | the patch passed |
| +1 :green_heart: | codespell | 1m 0s | | No new issues. |
| +1 :green_heart: | compile | 1m 38s | | the patch passed |
| +1 :green_heart: | javac | 1m 38s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 25s | | tez-dag: The patch generated 0 new + 111 unchanged - 2 fixed = 111 total (was 113) |
| +1 :green_heart: | checkstyle | 0m 35s | | root: The patch generated 0 new + 111 unchanged - 2 fixed = 111 total (was 113) |
| +1 :green_heart: | shellcheck | 0m 2s | | No new issues. |
| +1 :green_heart: | javadoc | 1m 18s | | the patch passed |
| +1 :green_heart: | spotbugs | 5m 13s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 50s | | tez-dag in the patch passed. |
| +1 :green_heart: | unit | 59m 48s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 52s | | The patch does not generate ASF License warnings. |
| | | 92m 40s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/481 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs javac javadoc unit spotbugs checkstyle compile |
| uname | Linux 11f22fb961e3 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh |
| git revision | master / 035e15936bb52a1a97fd887fb48232c9c2bbb5bd |
| Default Java | Ubuntu-21.0.10+7-Ubuntu-124.04 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/2/testReport/ |
| Max. process+thread count | 1336 (vs. ulimit of 5500) |
| modules | C: tez-dag . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/2/console |
| versions | git=2.43.0 maven=3.9.14 spotbugs=4.9.3 codespell=2.4.1 shellcheck=0.7.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4252926711
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 11s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | codespell | 0m 6s | | No new issues. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not generate ASF License warnings. |
| | | 0m 54s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/481 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs |
| uname | Linux 12a60895c737 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh |
| git revision | master / faf4957430c5c609f663da0782d9e9287337588a |
| Max. process+thread count | 57 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/4/console |
| versions | git=2.43.0 maven=3.9.14 codespell=2.4.1 shellcheck=0.7.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4364592815
ok, closing this PR then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3085370177
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.
Review Comment:
i guess no where 😬, only github emoji by yetus are coming.
##########
tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java:
##########
@@ -958,7 +958,7 @@ public DAGStatusBuilder getDAGStatus(Set<StatusGetOpts> statusOptions) {
public DAGStatusBuilder getDAGStatus(Set<StatusGetOpts> statusOptions,
long timeoutMillis) throws TezException {
- long timeoutNanos = timeoutMillis * 1000l * 1000l;
+ long timeoutNanos = timeoutMillis * 1000L * 1000L;
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4336183389
> What is the motivation behind this?
>
> This has been discussed in hadoop as well & blocked every time: [apache/hadoop#6937 (comment)](https://github.com/apache/hadoop/pull/6937#issuecomment-2221002917)
>
> The ticket mentioned in the Jira
>
> > This is the same as [HADOOP-16611](https://issues.apache.org/jira/browse/HADOOP-16611) but for Tez
>
> This is also resolved as `Not a Problem` The PR linked was also abandoned: [apache/hadoop#1523 (comment)](https://github.com/apache/hadoop/pull/1523#issuecomment-535461886)
@ayushtkn , for changes in README, pom, Jenkinsfile or Dockerfile, it doesn't contains UT and it give `-1` as overall yetus outcome.
One can argue for Java changes if no UT is there then `-1` is correct behaviour but I don't see any file extension based decision making in yetus.
In `build-tools/test-patch.sh` checkTests(), the behaviour is if "documentation" keyword is present in PR title then it will not give -1 (I've not tested this behaviour)
```
testReferences=`$GREP -c -i -e '^+++.*/test' $PATCH_DIR/patch`
echo "There appear to be $testReferences test files referenced in the patch."
if [[ $testReferences == 0 ]] ; then
if [[ $JENKINS == "true" ]] ; then
patchIsDoc=`$GREP -c -i 'title="documentation' $PATCH_DIR/jira`
if [[ $patchIsDoc != 0 ]] ; then
echo "The patch appears to be a documentation patch that doesn't require tests."
JIRA_COMMENT="$JIRA_COMMENT
{color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests."
return 0
fi
fi
JIRA_COMMENT="$JIRA_COMMENT
```
**All in all its a PMC's decision what behaviour is more favourable for the project in long run** . Please discuss among yourselves and let me know if I need to close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3085274504
##########
tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java:
##########
@@ -958,7 +958,7 @@ public DAGStatusBuilder getDAGStatus(Set<StatusGetOpts> statusOptions) {
public DAGStatusBuilder getDAGStatus(Set<StatusGetOpts> statusOptions,
long timeoutMillis) throws TezException {
- long timeoutNanos = timeoutMillis * 1000l * 1000l;
+ long timeoutNanos = timeoutMillis * 1000L * 1000L;
Review Comment:
I think you can revert this when the patch is fully finalized and approved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4245296351
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 5m 2s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | codespell | 0m 5s | | No new issues. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | shellcheck | 0m 2s | | No new issues. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | | The patch does not generate ASF License warnings. |
| | | 5m 50s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/481 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs |
| uname | Linux 344de02a5d04 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh |
| git revision | master / 573c3bb6c917475a2e2b514f8f3a587e26ffbe10 |
| Max. process+thread count | 51 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/1/console |
| versions | git=2.43.0 maven=3.9.14 codespell=2.4.1 shellcheck=0.7.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3086188102
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.
Review Comment:
hmm,
Here is the scenario i'm thinking:
1. If in a PR new tests are added:
- UT passed (unit): +1 green
- UT failed (unit): -1 red
- test4testsL +1 green
2. If no new UT were added:
- test4tests): -0 orange irrespective of UT failure as they are handled be unit
I'm little confused. let me test few things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3086017914
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.
Review Comment:
okay, we can consider removing test-patch.sh later if it turns out we don't use it at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4337587520
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | docker | 8m 40s | | Docker failed to build run-specific yetus/tez:tp-11071}. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/tez/pull/481 |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/5/console |
| versions | git=2.34.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4335849680
> i'll rebase and force push
thanks, feel free to rebase anything which was blocked on github actions issue and I'll check them again as soon as I can! 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3085562512
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.
Review Comment:
on JIRA also, no color and in github also no orange color. But i think its better to keep it orange. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4252561633
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 11s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 39s | | master passed |
| +1 :green_heart: | compile | 1m 35s | | master passed |
| +1 :green_heart: | checkstyle | 1m 2s | | master passed |
| +1 :green_heart: | javadoc | 1m 26s | | master passed |
| +0 :ok: | spotbugs | 0m 53s | | tez-api in master has 545 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 50s | | root in master has 1935 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 6s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 21s | | the patch passed |
| +1 :green_heart: | codespell | 0m 48s | | No new issues. |
| +1 :green_heart: | compile | 1m 32s | | the patch passed |
| +1 :green_heart: | javac | 1m 32s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 53s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 2s | | No new issues. |
| +1 :green_heart: | javadoc | 1m 14s | | the patch passed |
| +1 :green_heart: | spotbugs | 5m 0s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 1m 59s | [/patch-unit-tez-api.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/artifact/out/patch-unit-tez-api.txt) | tez-api in the patch passed. |
| -1 :x: | unit | 61m 52s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 55s | | The patch does not generate ASF License warnings. |
| | | 90m 52s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.common.TestTezCommonUtils |
| | tez.common.TestTezCommonUtils |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/481 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs javac javadoc unit spotbugs checkstyle compile |
| uname | Linux 20f709d1daeb 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-481/src/.yetus/personality.sh |
| git revision | master / 462e10e8293ed113834521850ad678027bf3c83e |
| Default Java | Ubuntu-21.0.10+7-Ubuntu-124.04 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/testReport/ |
| Max. process+thread count | 1348 (vs. ulimit of 5500) |
| modules | C: tez-api . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-481/3/console |
| versions | git=2.43.0 maven=3.9.14 spotbugs=4.9.3 codespell=2.4.1 shellcheck=0.7.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4335839818
i'll rebase and force push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3080594868
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.
Review Comment:
Used reference for color from yetus project.
https://github.com/apache/yetus/blob/45b8e4bbb994045f1d7d78a76d556e93f4faf3ed/precommit/src/main/shell/plugins.d/jira.sh#L494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3085268450
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.
Review Comment:
where can I see the effect of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3086188102
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to include any new or modified tests.
Review Comment:
hmm,
Here is the scenario i'm thinking:
1. If in a PR new tests are added:
- UT passed: +1 green
- UT failed: -1 red
2. If no new UT were added:
- UT passed: -0 orange
- UT failed: -1 red
I think adding test4tests `--tests-filter` will always make `-0` even in case of UT failure where `-1` should be given. Need to play around `test-patch.sh` only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4363091296
> > What is the motivation behind this?
> > This has been discussed in hadoop as well & blocked every time: [apache/hadoop#6937 (comment)](https://github.com/apache/hadoop/pull/6937#issuecomment-2221002917)
> > The ticket mentioned in the Jira
> > > This is the same as [HADOOP-16611](https://issues.apache.org/jira/browse/HADOOP-16611) but for Tez
> >
> >
> > This is also resolved as `Not a Problem` The PR linked was also abandoned: [apache/hadoop#1523 (comment)](https://github.com/apache/hadoop/pull/1523#issuecomment-535461886)
>
> @ayushtkn , for changes in README, pom, Jenkinsfile or Dockerfile, it doesn't contains UT and it give `-1` as overall yetus outcome. One can argue for Java changes if no UT is there then `-1` is correct behaviour but I don't see any file extension based decision making in yetus.
>
> In `build-tools/test-patch.sh` checkTests(), the behaviour is if "documentation" keyword is present in PR title then it will not give -1 (I've not tested this behaviour)
>
> ```
> testReferences=`$GREP -c -i -e '^+++.*/test' $PATCH_DIR/patch`
> echo "There appear to be $testReferences test files referenced in the patch."
> if [[ $testReferences == 0 ]] ; then
> if [[ $JENKINS == "true" ]] ; then
> patchIsDoc=`$GREP -c -i 'title="documentation' $PATCH_DIR/jira`
> if [[ $patchIsDoc != 0 ]] ; then
> echo "The patch appears to be a documentation patch that doesn't require tests."
> JIRA_COMMENT="$JIRA_COMMENT
>
> {color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests."
> return 0
> fi
> fi
> JIRA_COMMENT="$JIRA_COMMENT
> ```
>
> **All in all its a PMC's decision what behaviour is more favourable for the project in long run** . Please discuss among yourselves and let me know if I need to close this PR.
no strong opinions about this, ultimately it's about the confetti_ball vs. broken_heart icon on top of the yetus report, but it doesn't break the pipeline, and lets the reviewer decide whether the patch is correct and merge, I'm fine with keeping as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav closed pull request #481: TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez
URL: https://github.com/apache/tez/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4705: Make Yetus test4tests vote for -0 instead of -1 for Tez [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #481:
URL: https://github.com/apache/tez/pull/481#issuecomment-4245310152
I'll make 1 checkstyle fix i.e. java change to trigger the `test4tests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org