You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Roland Weber (JIRA)" <ji...@apache.org> on 2007/07/13 15:37:04 UTC
[jira] Closed: (HTTPCORE-91) bad constant names in
o.a.h.protocol.HTTP
[ https://issues.apache.org/jira/browse/HTTPCORE-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roland Weber closed HTTPCORE-91.
--------------------------------
Resolution: Fixed
Done. I also changed RequestDate and ResponseDate interceptors to not overwrite an existing Date header.
The NHttpReverseProxy example no longer removes the Server header, it is not a connection header.
cheers,
Roland
> bad constant names in o.a.h.protocol.HTTP
> -----------------------------------------
>
> Key: HTTPCORE-91
> URL: https://issues.apache.org/jira/browse/HTTPCORE-91
> Project: HttpComponents Core
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.0-alpha5
> Reporter: Roland Weber
> Assignee: Roland Weber
> Priority: Trivial
> Fix For: 4.0-beta1
>
>
> Class org.apache.http.protocol.HTTP defines some constants with inappropriate names:
> public static final String DATE_DIRECTIVE = "Date";
> public static final String SERVER_DIRECTIVE = "Server";
> neither of these is a "directive" in any way. They are plain, informational headers.
> public static final String EXPECT_DIRECTIVE = "Expect";
> public static final String CONN_DIRECTIVE = "Connection";
> While these are not termed "directive" in RFC 2616, they do have that character.
> I suggest to rename DATE_DIRECTIVE and SERVER_DIRECTIVE to *_HEADER or *_INFO.
> Within core, this would affect o.a.h.protocol, related tests, and NIO example NHttpReverseProxy.
> cheers,
> Roland
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org