You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "rtib (via GitHub)" <gi...@apache.org> on 2024/06/14 20:43:13 UTC
[PR] [CASSANDRA-19706] Enable colored output of nodetool status [cassandra]
rtib opened a new pull request, #3377:
URL: https://github.com/apache/cassandra/pull/3377
This improves the readability of nodetool status' output by enabling colored status lines for nodes joining, leaving or moving printed yellow and nodes not up printed red.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-19706] Enable colored output of nodetool status [cassandra]
Posted by "rtib (via GitHub)" <gi...@apache.org>.
rtib commented on PR #3377:
URL: https://github.com/apache/cassandra/pull/3377#issuecomment-2371734074
> Some environments might not support ANSI color codes, so it would be good to add detection for environments that don't support it, and either default to non-colored output or provide a clear error/warning.
Well, that was the idea with the environment variables to activate the feature. They're set in the environments which support ANSI colors. But, as this is going to be part of the reengineering work ongoing with [CASSANDRA-17445](https://issues.apache.org/jira/browse/CASSANDRA-17445), the coloring will be implemented with PicoCLI, which is auto-detecting terminal features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] [CASSANDRA-19706] Enable colored output of nodetool status [cassandra]
Posted by "Spy156 (via GitHub)" <gi...@apache.org>.
Spy156 commented on PR #3377:
URL: https://github.com/apache/cassandra/pull/3377#issuecomment-2371459148
Some environments might not support ANSI color codes, so it would be good to add detection for environments that don't support it, and either default to non-colored output or provide a clear error/warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org