[GitHub] [logging-log4cxx] rm5248 commented on pull request #96: Reduce indirection in Logger and Hiearchy implementations

[GitBox <gi...@apache.org>]

rm5248 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004427963


   Looks good to me.
   
   The ABI failure is not due to this change, but due to some of the other changes that you've made(e.g. returning a reference instead of the `shared_ptr`).  At some point it would be interesting to see if there is a significant speed difference returning a reference vs. the `shared_ptr` - I would be concerned that returning a reference to a `shared_ptr` (and it seems that modern compilers [may not have an issue with this anyway](https://stackoverflow.com/questions/10643563/how-to-return-smart-pointers-shared-ptr-by-reference-or-by-value)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org