[GitHub] [hbase] sunhelly commented on pull request #4788: HBASE-21521 Expose master startup status via web UI

[GitBox <gi...@apache.org>]

sunhelly commented on PR #4788:
URL: https://github.com/apache/hbase/pull/4788#issuecomment-1248894587

   Thanks, @Apache9 . The `TaskGroup` idea is from @apurtell 's comments at https://github.com/apache/hbase/pull/3667, 'It works, but it would be cleaner if somehow Phases can be MonitoredTasks. Take what we have already for task monitoring and add the ability to group them. Startup activity can be the first official grouping.'
   
   From my perspective,  the `TaskGroup` can be seen as a big `MonitoredTask`, which contains a list of sub-monitoredTasks. The monitored tasks in the group are still be managed by the `TaskMonitor`, but whether to clear/expire the monitored tasks in a task group is optional. Since the monitored task already has journals, which mark the phases in a task, we still also need a task group to monitor a big task/process because I think the jourals in a task is serial but the tasks in the task group can be parallel(though haven't yet), then we have more flexible ability to monitor the process.
   
   Here for the master startup process, we use `TaskGroup` to monitor the whole progress, and use `MonitoredTask`s to mark key phases, for which use journals to monitor sub-phases. The `TaskMonitor` needs not to clear the startup process tasks, we can see the startup progress info from the UI whenever we need.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org