[GitHub] [incubator-iceberg] electrum commented on issue #234: Make BaseTransaction public

[GitBox <gi...@apache.org>]

electrum commented on issue #234: Make BaseTransaction public
URL: https://github.com/apache/incubator-iceberg/pull/234#issuecomment-505937968
 
 
   I’m using this to create a `Transaction` instance directly, without using `BaseMetastoreTables` (as we have an alternate implementation).
   
   Do you want a new `Transactions` class, or should they be static methods on the `Transaction` interface? The latter seems to be the favored way for Java 8 (it’s why they added static methods for interfaces).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org