You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/29 13:20:37 UTC

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1289: MINIFICPP-1783 Encrypted values in agent manifest should remain in encrypted form

adam-markovics commented on a change in pull request #1289:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1289#discussion_r837466700



##########
File path: libminifi/test/integration/IntegrationBase.h
##########
@@ -61,6 +61,10 @@ class IntegrationBase {
     return configuration;
   }
 
+  void setConfiguration(std::shared_ptr<minifi::Configure> configuration) {
+    this->configuration = configuration;

Review comment:
       I'd rather `std::move` the parameter if it's stored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org