[jira] [Commented] (IMPALA-11375) impala-shell: log important message for rpc requests/response

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676376#comment-17676376 ] 

ASF subversion and git services commented on IMPALA-11375:
----------------------------------------------------------

Commit f2f6b4b5804df036a5a7dc8ff23f8a0537b5bf97 in impala's branch refs/heads/master from jasonmfehr
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f2f6b4b58 ]

IMPALA-11375 Impala shell outputs details of each RPC

When the Impala shell is using the hs2 protocol, it makes multiple RPCs
to the Impala daemon.  These calls pass Thrift objects back and forth.
This change adds the '--show_rpc' which outputs the details of the RPCs
to stdout and the '--rpc_file' flag which outputs the RPC details to the
specified file path.

RPC details include:
- operation name
- request attempt count
- Impala session/query ids (if applicable)
- call duration
- call status (success/failure)
- request Thrift objects
- response Thrift objects

Certain information is not included in the RPC details:
- Thrift object attributes named 'secret' or 'password'
  are redacted.
- Thrift objects with a type of TRowSet or TGetRuntimeProfileResp
  are not include as the information contained within them is
  already available in the standard output from the Impala shell.

Testing:
- Added new tests in the end-to-end test suite.

Change-Id: I36f8dbc96726aa2a573133acbe8a558299381f8b
Reviewed-on: http://gerrit.cloudera.org:8080/19388
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> impala-shell: log important message for rpc requests/response
> -------------------------------------------------------------
>
>                 Key: IMPALA-11375
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11375
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: Abhishek Rawat
>            Assignee: Jason Fehr
>            Priority: Major
>
> impala-shell client logs can be improved to add logs when an rpc request is sent/received.
> Also, would be good to add 'X-Request-ID' in the http header for hs2-http mode. This is useful for tracing end to end logs when using a reverse proxy such as nginx. Would be good to include the X-Request-ID in the server logs also, when it logs rpc requests and responses.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org