Re: Review Request 31837: Fix for caret issues in Chrome+Linux with periods and apostrophes

["Vicente J. Ruiz Jurado" <vj...@ourproject.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31837/#review159632
-----------------------------------------------------------



Closing this review because an undated PR by @pablojan
https://github.com/apache/incubator-wave/pull/18

- Vicente J. Ruiz Jurado


On Mar. 9, 2015, 12:23 a.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31837/
> -----------------------------------------------------------
> 
> (Updated Mar. 9, 2015, 12:23 a.m.)
> 
> 
> Review request for wave, Andrew Kaplanov, Pablo Ojanguren, and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> This patch fix a issue in Chrome+Linux with periods and apostrophes. For instance if you type:
> 
> ...abc...
> 
> the result must be
> 
> ...abc...| 
> 
> (where | is the caret/cursor), but instead you get:
> 
> abc|......
> 
> and the same whith apostrophes:
> 
> abc|''''''
> 
> It seems that this issue is not present in wiab.pro so maybe is interesting the review of akaplanov.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/common/util/SignalKeyLogic.java 5da169a 
> 
> Diff: https://reviews.apache.org/r/31837/diff/
> 
> 
> Testing
> -------
> 
> ant waveharness-superdev tested in FF and Chrome (Linux) and Chorme in Mac.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>