You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/04/07 07:45:57 UTC

[GitHub] [calcite] asolimando commented on pull request #2767: [CALCITE-5027] Incorrect format for timestamp literals

asolimando commented on PR #2767:
URL: https://github.com/apache/calcite/pull/2767#issuecomment-1091214632

   @NobiGo, did you try implementing a test via SQL and extract function as Julian suggested in the Jira ticket? 
   
   Such a test would be more self-describing and easier to check/understand w.r.t. one based on ms from epoch like in your test. 
   
   IMO the PR is already valuable as-is, but it would be even better with such a test in place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org