You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/04/08 21:01:55 UTC
Review Request 45939: Remove support for positional command line
arguments,
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45939/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
We don't make use of this feature, and i don't foresee us doing so.
Diffs
-----
commons-args/src/main/java/org/apache/aurora/common/args/Positional.java 1c6f86f0b400a58a6517ba21b6fb67da2a95ac7e
commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java d531ba0d3fc6409eb158b123e0b84a1a1979c942
commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java b526dd0e34668957cdfbe1e35afa652176e15f14
commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 908553ce2fdb16d0e69b458823deb7f165550b93
commons/src/main/java/org/apache/aurora/common/args/Args.java 1983fd9aae64942266612cf9ed3bdcccfa096e3c
commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 48737d4a831ab62945e48e4b9540a18ca2e2abab
commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java a4d74ed9d9093939dbaf088ba2a8a632b2a7f1c5
commons/src/test/java/org/apache/aurora/common/args/ArgsTest.java 4ffc7941a856eb63547b9cb4708fb3bfb0eed562
Diff: https://reviews.apache.org/r/45939/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 45939: Remove support for positional command line
arguments,
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45939/#review127856
-----------------------------------------------------------
Master (bd90d76) is red with this patch.
./build-support/jenkins/build.sh
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean UP-TO-DATE
:api:clean UP-TO-DATE
:buildSrc:clean UP-TO-DATE
:commons:clean UP-TO-DATE
:commons-args:clean UP-TO-DATE
:enforceVersion UP-TO-DATE
:api:generateThriftJava
make: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
sha256=$(curl -s --show-error https://archive.apache.org/dist/thrift/0.9.1/thrift-0.9.1.tar.gz | tee thrift-0.9.1.tar.gz | openssl dgst -sha256 | cut -d' ' -f2) && \
[ "${sha256}" = "ac175080c8cac567b0331e394f23ac306472c071628396db2850cb00c41b0017" ] && \
tar zxvf thrift-0.9.1.tar.gz && \
cd thrift-0.9.1 && \
sha256=$(curl -s --show-error https://issues.apache.org/jira/secure/attachment/12632477/yylex.patch | tee thrift.patch | openssl dgst -sha256 | cut -d' ' -f2) && \
[ "${sha256}" = "70f20b4e5b2e004b8a0d075b80a52750bce5be02ed83efdc60adbc45ec386a6c" ] && \
patch -p1 < thrift.patch && \
./configure --disable-dependency-tracking --disable-shared --without-c_glib --without-cpp --without-csharp --without-d --without-erlang --without-go --without-java --without-haskell --without-perl --without-php --without-php_extension --without-pic --without-python --without-qt4 --without-ruby --without-tests && \
make -j4
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:generateThriftJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw'' finished with non-zero exit value 2
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 4.942 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 8, 2016, 7:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45939/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 7:27 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We don't make use of this feature, and i don't foresee us doing so.
>
>
> Diffs
> -----
>
> commons-args/src/main/java/org/apache/aurora/common/args/Positional.java 1c6f86f0b400a58a6517ba21b6fb67da2a95ac7e
> commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java d531ba0d3fc6409eb158b123e0b84a1a1979c942
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java b526dd0e34668957cdfbe1e35afa652176e15f14
> commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 306ca4dc6b8380413d26246e0155f1f8da6ce84e
> commons/src/main/java/org/apache/aurora/common/args/Args.java 1983fd9aae64942266612cf9ed3bdcccfa096e3c
> commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 83d9cd53ab02c661912a3911ebd81299daffd6ad
> commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java 6ac518a5c7b13deb5031bf27897e2b62e4d1fda5
> commons/src/test/java/org/apache/aurora/common/args/ArgsTest.java 4ffc7941a856eb63547b9cb4708fb3bfb0eed562
>
> Diff: https://reviews.apache.org/r/45939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45939: Remove support for positional command line
arguments,
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45939/
-----------------------------------------------------------
(Updated April 8, 2016, 12:27 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
rebase
Repository: aurora
Description
-------
We don't make use of this feature, and i don't foresee us doing so.
Diffs (updated)
-----
commons-args/src/main/java/org/apache/aurora/common/args/Positional.java 1c6f86f0b400a58a6517ba21b6fb67da2a95ac7e
commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java d531ba0d3fc6409eb158b123e0b84a1a1979c942
commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java b526dd0e34668957cdfbe1e35afa652176e15f14
commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 306ca4dc6b8380413d26246e0155f1f8da6ce84e
commons/src/main/java/org/apache/aurora/common/args/Args.java 1983fd9aae64942266612cf9ed3bdcccfa096e3c
commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 83d9cd53ab02c661912a3911ebd81299daffd6ad
commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java 6ac518a5c7b13deb5031bf27897e2b62e4d1fda5
commons/src/test/java/org/apache/aurora/common/args/ArgsTest.java 4ffc7941a856eb63547b9cb4708fb3bfb0eed562
Diff: https://reviews.apache.org/r/45939/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 45939: Remove support for positional command line
arguments,
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45939/#review127844
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 8, 2016, 12:01 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45939/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:01 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We don't make use of this feature, and i don't foresee us doing so.
>
>
> Diffs
> -----
>
> commons-args/src/main/java/org/apache/aurora/common/args/Positional.java 1c6f86f0b400a58a6517ba21b6fb67da2a95ac7e
> commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java d531ba0d3fc6409eb158b123e0b84a1a1979c942
> commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java b526dd0e34668957cdfbe1e35afa652176e15f14
> commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java 908553ce2fdb16d0e69b458823deb7f165550b93
> commons/src/main/java/org/apache/aurora/common/args/Args.java 1983fd9aae64942266612cf9ed3bdcccfa096e3c
> commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java 48737d4a831ab62945e48e4b9540a18ca2e2abab
> commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java a4d74ed9d9093939dbaf088ba2a8a632b2a7f1c5
> commons/src/test/java/org/apache/aurora/common/args/ArgsTest.java 4ffc7941a856eb63547b9cb4708fb3bfb0eed562
>
> Diff: https://reviews.apache.org/r/45939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>