[jira] [Comment Edited] (TAMAYA-232) Implementation of ConfigurationChange is not consistent

["Oliver B. Fischer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAMAYA-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852738#comment-15852738 ] 

Oliver B. Fischer edited comment on TAMAYA-232 at 2/4/17 10:27 AM:
-------------------------------------------------------------------

[~anatole]: Two questions:

* Can I move both meta entries _\_id_ and _\_frozenAt_ to class members? 
* Should _isEmpty()_ always ignore entries starting with an underscore?


was (Author: o.b.fischer):
[~anatole] Two questions:

* Can I move both meta entries _\_id_ and _\_frozenAt_ to class members? 
* Should _isEmpty()_ always ignore entries starting with an underscore?

> Implementation of ConfigurationChange is not consistent
> -------------------------------------------------------
>
>                 Key: TAMAYA-232
>                 URL: https://issues.apache.org/jira/browse/TAMAYA-232
>             Project: Tamaya
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 0.3-incubating
>            Reporter: Oliver B. Fischer
>            Assignee: Oliver B. Fischer
>             Fix For: 0.3-incubating
>
>
> The implementation of {{ConfigurationChange}} is not consistent. While the methods {{getAddedSize()}}, {{getRemovedSize()}} and {{getUpdatedSize()}} ignore properties starting with the prefix {{_}} ignore, does {{isEmpty()}} simply counts the number changes without the same filtering mechnism. 
> This leeds the to unneeded fired events, as the method {{isEmpty()}} is used by {{checkConfigurationUpdate()}} of {{DefaultConfigChangeObserver}} returns always {{false}}.
> At the moment every {{ConfigurationChange}} contains two properties starting with {{_}} which have been added to {{FrozenConfiguration}} during its construction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)