You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/01 12:03:08 UTC

[GitHub] [pulsar] RobertIndie opened a new pull request #10769: [Kinesis] Fix kinesis sink connector does not ack messages

RobertIndie opened a new pull request #10769:
URL: https://github.com/apache/pulsar/pull/10769


   
   ### Motivation
   
   Currently, when the kinesis sink connector sends the message successfully, it will not ack the message.
   
   ### Modifications
   
   * Ack messages after the sink connector send messages successfully.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dlg99 commented on pull request #10769: [Kinesis] Fix kinesis sink connector does not ack messages

Posted by GitBox <gi...@apache.org>.

dlg99 commented on pull request #10769:
URL: https://github.com/apache/pulsar/pull/10769#issuecomment-852243133


   @tuteng shouldn't it also do `this.resultContext.fail()` in the `onFailure()` case to nack the message?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #10769: [Kinesis] Fix kinesis sink connector does not ack messages

Posted by GitBox <gi...@apache.org>.

sijie commented on pull request #10769:
URL: https://github.com/apache/pulsar/pull/10769#issuecomment-852290933


   @dlg99 there is a retry logic in the `onFailure` part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10769: [Kinesis] Fix kinesis sink connector does not ack messages

Posted by GitBox <gi...@apache.org>.

codelipenghui merged pull request #10769:
URL: https://github.com/apache/pulsar/pull/10769


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #10769: [Kinesis] Fix kinesis sink connector does not ack messages

Posted by GitBox <gi...@apache.org>.

eolivelli commented on pull request #10769:
URL: https://github.com/apache/pulsar/pull/10769#issuecomment-852087120


   @dlg99 FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org