You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sb...@pivotal.io> on 2016/06/17 23:48:21 UTC
Re: Review Request 48889: GEODE-1493: config/gemfire.properties that
is shipped with the geode distribution contains user specific info
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48889/
-----------------------------------------------------------
(Updated June 17, 2016, 11:48 p.m.)
Review request for geode and Dan Smith.
Summary (updated)
-----------------
GEODE-1493: config/gemfire.properties that is shipped with the geode distribution contains user specific info
Bugs: GEODE-1493
https://issues.apache.org/jira/browse/GEODE-1493
Repository: geode
Description (updated)
-------
* removed code to change default mcast address based on machine
* Made default cluster config dir is empty
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java c7eca0fcc72c93a198c31133434d141c39922d44
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java b793e34ba656d1a05cb9f27d31e51c1109394698
Diff: https://reviews.apache.org/r/48889/diff/
Testing
-------
Thanks,
Sai Boorlagadda
Re: Review Request 48889: GEODE-1493: config/gemfire.properties that
is shipped with the geode distribution contains user specific info
Posted by Sai Boorlagadda <sb...@pivotal.io>.
> On June 20, 2016, 5:59 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java, line 283
> > <https://reviews.apache.org/r/48889/diff/1/?file=1423178#file1423178line283>
> >
> > How is this change related to ipv6...
> >
> > Currently the default config dir gets sets to current working directory...Does changing it to "" has any impact on that...It it has, it may affect existing customers/users...
> >
> > The bug title talks about user specific info, are these changes related...Sorry i was unable to access the ticket...
Changes to IPv6 and cluster-config are unreleaste.
The ticket is to avoid any user(build-machine) specific details getting into the gemfire.properties, the default config shipped with geode distribution. Two such user (build-machine) specific things found are:
1) cluster-config-dir - using current working directory.
2) mcast-address - current code checks build-machine`s network configuration to provide default mcast-address (IPv4 vs IPv6).
The properties are dumped using DistributionConfigImpl.java, which outputs the default values for most of the properties.
The user/developer can edit gemfire.properties and change the cluster-config-dir or any other property.
And having IPv4 mcast address as default is taken care by JGroups, so if user builds the binary on an IPv4 and runs it on an IPv6, JGroups converts mcast address to equivalent IPv6 address.
- Sai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48889/#review138646
-----------------------------------------------------------
On June 17, 2016, 11:48 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48889/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 11:48 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1493
> https://issues.apache.org/jira/browse/GEODE-1493
>
>
> Repository: geode
>
>
> Description
> -------
>
> * removed code to change default mcast address based on machine
> * Made default cluster config dir is empty
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java c7eca0fcc72c93a198c31133434d141c39922d44
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java b793e34ba656d1a05cb9f27d31e51c1109394698
>
> Diff: https://reviews.apache.org/r/48889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sai Boorlagadda
>
>
Re: Review Request 48889: GEODE-1493: config/gemfire.properties that
is shipped with the geode distribution contains user specific info
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48889/#review138646
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java (line 283)
<https://reviews.apache.org/r/48889/#comment203845>
How is this change related to ipv6...
Currently the default config dir gets sets to current working directory...Does changing it to "" has any impact on that...It it has, it may affect existing customers/users...
The bug title talks about user specific info, are these changes related...Sorry i was unable to access the ticket...
- anilkumar gingade
On June 17, 2016, 11:48 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48889/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 11:48 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1493
> https://issues.apache.org/jira/browse/GEODE-1493
>
>
> Repository: geode
>
>
> Description
> -------
>
> * removed code to change default mcast address based on machine
> * Made default cluster config dir is empty
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java c7eca0fcc72c93a198c31133434d141c39922d44
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java b793e34ba656d1a05cb9f27d31e51c1109394698
>
> Diff: https://reviews.apache.org/r/48889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sai Boorlagadda
>
>
Re: Review Request 48889: GEODE-1493: config/gemfire.properties that
is shipped with the geode distribution contains user specific info
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48889/#review138360
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On June 17, 2016, 11:48 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48889/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 11:48 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1493
> https://issues.apache.org/jira/browse/GEODE-1493
>
>
> Repository: geode
>
>
> Description
> -------
>
> * removed code to change default mcast address based on machine
> * Made default cluster config dir is empty
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java c7eca0fcc72c93a198c31133434d141c39922d44
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java b793e34ba656d1a05cb9f27d31e51c1109394698
>
> Diff: https://reviews.apache.org/r/48889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sai Boorlagadda
>
>
Re: Review Request 48889: GEODE-1493: config/gemfire.properties that
is shipped with the geode distribution contains user specific info
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48889/#review138428
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On June 17, 2016, 11:48 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48889/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 11:48 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-1493
> https://issues.apache.org/jira/browse/GEODE-1493
>
>
> Repository: geode
>
>
> Description
> -------
>
> * removed code to change default mcast address based on machine
> * Made default cluster config dir is empty
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java c7eca0fcc72c93a198c31133434d141c39922d44
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java b793e34ba656d1a05cb9f27d31e51c1109394698
>
> Diff: https://reviews.apache.org/r/48889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sai Boorlagadda
>
>