You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/22 06:11:51 UTC

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5547: [Compile][Refactor] fix some warning in gcc higher than 7

yangzhg commented on a change in pull request #5547:
URL: https://github.com/apache/incubator-doris/pull/5547#discussion_r598446741



##########
File path: be/src/olap/decimal12.h
##########
@@ -156,6 +139,8 @@ struct decimal12_t {
     int32_t fraction;
 } __attribute__((packed));
 
+static_assert(std::is_trivial<decimal12_t>::value, "decimal12_t should be a pod type");

Review comment:
       use POD 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org