You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/11/19 02:45:11 UTC

[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2063: [improve] job submit parameter improvement

wolfboys opened a new pull request, #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063

   [improve] job submit parameter improvement
   
   ## What changes were proposed in this pull request
   
   Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
   
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verifying this change
   
   <!--*(Please pick either of the following options)*-->
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added integration tests for end-to-end.*
   - *Added *Test to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2063: [improve] job submit parameter improvement

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063#issuecomment-1320764315

   cc @1996fanrui @MonsterChenzhuo PTAL, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] macksonmu commented on a diff in pull request #2063: [improve] job submit parameter improvement

Posted by GitBox <gi...@apache.org>.
macksonmu commented on code in PR #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063#discussion_r1027260574


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/AppBuildPipeServiceImpl.java:
##########
@@ -445,16 +445,13 @@ public Map<Long, PipelineStatus> listPipelineStatus(List<Long> appIds) {
             return Maps.newHashMap();
         }
         LambdaQueryWrapper<AppBuildPipeline> queryWrapper = new LambdaQueryWrapper<AppBuildPipeline>()
-            .select(AppBuildPipeline::getAppId, AppBuildPipeline::getPipeStatusCode)
             .in(AppBuildPipeline::getAppId, appIds);
-        List<Map<String, Object>> rMaps = baseMapper.selectMaps(queryWrapper);
+
+        List<AppBuildPipeline> rMaps = baseMapper.selectList(queryWrapper);

Review Comment:
   Should the name of the variable `rMaps` be changed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2063: [improve] job submit parameter improvement

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063#issuecomment-1321136189

   > @wolfboys Except that the naming of the variable `rMaps` needs to be standardized, I have not found any other problems. I will test it as a whole after the merger
   
   done. thanks for your review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2063: [improve] job submit parameter improvement

Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063#discussion_r1027286814


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/AppBuildPipeServiceImpl.java:
##########
@@ -445,16 +445,13 @@ public Map<Long, PipelineStatus> listPipelineStatus(List<Long> appIds) {
             return Maps.newHashMap();
         }
         LambdaQueryWrapper<AppBuildPipeline> queryWrapper = new LambdaQueryWrapper<AppBuildPipeline>()
-            .select(AppBuildPipeline::getAppId, AppBuildPipeline::getPipeStatusCode)
             .in(AppBuildPipeline::getAppId, appIds);
-        List<Map<String, Object>> rMaps = baseMapper.selectMaps(queryWrapper);
+
+        List<AppBuildPipeline> rMaps = baseMapper.selectList(queryWrapper);

Review Comment:
   > @wolfboys Except that the naming of the variable `rMaps` needs to be standardized, I have not found any other problems. I will test it as a whole after the merger
   
   thanks for your review. I will improve what you mentioned



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] MonsterChenzhuo commented on pull request #2063: [improve] job submit parameter improvement

Posted by GitBox <gi...@apache.org>.
MonsterChenzhuo commented on PR #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063#issuecomment-1321139689

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] MonsterChenzhuo merged pull request #2063: [improve] job submit parameter improvement

Posted by GitBox <gi...@apache.org>.
MonsterChenzhuo merged PR #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org