[GitHub] [spark] HeartSaVioR commented on a change in pull request #26821: [SPARK-20656][CORE]Support Incremental parsing of event logs in SHS

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #26821: [SPARK-20656][CORE]Support Incremental parsing of event logs in SHS
URL: https://github.com/apache/spark/pull/26821#discussion_r356982819
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
 ##########
 @@ -129,6 +129,13 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
 
   private val storePath = conf.get(LOCAL_STORE_DIR).map(new File(_))
   private val fastInProgressParsing = conf.get(FAST_IN_PROGRESS_PARSING)
+  // If incremental parsing support configuration is enabled, underlying store will not close
+  // during invalidate UI or detached UI. Metadata of the event read will store in the
+  // `IncrmentalInfo`. Whenever a new event come, parsing will happen from the line it
+  // read last time. Currently it supports inmemory store. TODO: Support for disk store.
+  private val isIncrementalParsingEnabled = storePath.isEmpty &&
 
 Review comment:
   We seem to not add `is`/`are` in the name of value even it's expected to return Boolean. Nearest example is `fastInProgressParsing`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org