You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/13 06:43:11 UTC
[GitHub] [incubator-inlong] woofyzhao opened a new pull request, #4192: [INLONG-4099][Manager] iceberg sink resource operator
woofyzhao opened a new pull request, #4192:
URL: https://github.com/apache/incubator-inlong/pull/4192
Feature #4099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4192: [INLONG-4099][Manager] Support create Iceberg resource
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4192:
URL: https://github.com/apache/incubator-inlong/pull/4192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4192: [INLONG-4099][Manager] Support create Iceberg resource
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4192:
URL: https://github.com/apache/incubator-inlong/pull/4192#discussion_r873531478
##########
inlong-manager/manager-service/pom.xml:
##########
@@ -167,6 +167,55 @@
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-hive-metastore</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-metastore</artifactId>
Review Comment:
I found those files in `licenses/inlong-manager`, there was no problem for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4192: [INLONG-4099][Manager] Support create Iceberg resource
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4192:
URL: https://github.com/apache/incubator-inlong/pull/4192#discussion_r872196517
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/IcebergPartition.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.enums;
+
+import org.apache.inlong.manager.common.util.Preconditions;
+
+import java.util.Locale;
+
+public enum IcebergPartition {
Review Comment:
Please add Java docs for classes, enums, and public / static methods, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4192: [INLONG-4099][Manager] Support create Iceberg resource
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4192:
URL: https://github.com/apache/incubator-inlong/pull/4192#discussion_r873527909
##########
inlong-manager/manager-service/pom.xml:
##########
@@ -167,6 +167,55 @@
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-hive-metastore</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-metastore</artifactId>
Review Comment:
Please check the NOTICEs and LICENSEs of those dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4192: [INLONG-4099][Manager] Support create Iceberg resource
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4192:
URL: https://github.com/apache/incubator-inlong/pull/4192#discussion_r872992050
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/IcebergType.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.enums;
+
+import lombok.Getter;
+
+import java.util.Locale;
+
+/**
+ * Iceberg data type
+ */
+public enum IcebergType {
+
+ BOOLEAN("boolean"),
+ INT("int"),
+ LONG("long"),
+ FLOAT("float"),
+ DOUBLE("double"),
+ DECIMAL("decimal(P,S)"),
+ DATE("date"),
+ TIME("time"),
+ TIMESTAMP("timestamp"),
+ TIMESTAMPTZ("timestamptz"),
+ STRING("string"),
+ UUID("uuid"),
+ FIXED("fixed(L)"),
+ BINARY("binary");
+
+ @Getter
+ private String type;
+
+ IcebergType(String type) {
+ this.type = type;
+ }
+
+ /**
+ * Get type from name
+ */
+ public static IcebergType forType(String type) {
+ for (IcebergType ibType : values()) {
+ if (ibType.getType().toLowerCase(Locale.ROOT).equals(type.toLowerCase(Locale.ROOT))) {
Review Comment:
Maybe the `equalsIgnoreCase()` is a better way to check whether the two types were equals or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org