You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/04/12 16:43:33 UTC
[GitHub] [hop] shlxue opened a new pull request, #1459: HOP-3876 Using contrast color for foreground in text
shlxue opened a new pull request, #1459:
URL: https://github.com/apache/hop/pull/1459
Only change foreground in text control.
Hop-GUI seems to always use the same background when enable value is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1459: HOP-3876 Using contrast color for foreground in text
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1459:
URL: https://github.com/apache/hop/pull/1459#issuecomment-1097627821
Which OS did you check this on, because we have seen different behaviour between MacOs,Windows,linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1459: HOP-3876 Using contrast color for foreground in text
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1459:
URL: https://github.com/apache/hop/pull/1459#issuecomment-1097829010
we have to remove styledText because they do not work in hop web so I wouldn't focus too much on it...
We need to build/use a new Widget for styled texts that works on RAP too and then we can add sql syntax highlighting which we used to have before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1459: HOP-3876 Using contrast color for foreground in text
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1459:
URL: https://github.com/apache/hop/pull/1459#issuecomment-1097828896
I would like to replace SWT.COLOR_WIDGET_BACKGROUND with SWT.COLOR_TEXT_DISABLED_BACKGROUND.
but I am not sure if doing so will affect windows or linux platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1459: HOP-3876 Using contrast color for foreground in text
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1459:
URL: https://github.com/apache/hop/pull/1459#issuecomment-1097797568
Restored background.
Now, if enable value is true, it's ok.
but enable = false:
<img width="443" alt="macos-hop-gui-styletextcomp" src="https://user-images.githubusercontent.com/6229653/163144832-c220b474-2430-4c7d-956f-59ad8e4dfbe8.png">
I guess: SWT.COLOR_WIDGET_BACKGROUND != SWT.COLOR_TEXT_WIDGET_BACKGROUND on macOS, but don't found COLOR_TEXT_WIDGET_BACKGROUND in SWT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1459: HOP-3876 Using contrast color for foreground in text
Posted by GitBox <gi...@apache.org>.
hansva merged PR #1459:
URL: https://github.com/apache/hop/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1459: HOP-3876 Using contrast color for foreground in text
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1459:
URL: https://github.com/apache/hop/pull/1459#issuecomment-1097695432
macOS
| enable | Light | Dark |
|----|----|----|
|false|<img width="300" alt="origin-swt-enable-false" src="https://user-images.githubusercontent.com/6229653/163129229-3e370184-4fac-4e6f-b9fe-2a64159590d6.png">|<img width="300" alt="hop-theme-enable-false" src="https://user-images.githubusercontent.com/6229653/163129291-31de2ab2-8b95-4035-bebb-5ef895601091.png">|
|true|<img width="300" alt="origin-swt-enable-true" src="https://user-images.githubusercontent.com/6229653/163129248-ab25930e-44d4-41f2-a497-227f617d874e.png">|<img width="300" alt="hop-theme-enable-true" src="https://user-images.githubusercontent.com/6229653/163129329-bfd85476-7f5a-4f46-be24-3977b51c1c2e.png">|
|false|<img width="300" alt="origin-swt-enable-false dark" src="https://user-images.githubusercontent.com/6229653/163129349-8f3de3dc-c0ae-484c-89a9-ef778ea8065b.png">|<img width="300" alt="hop-theme-enable-true dark" src="https://user-images.githubusercontent.com/6229653/163129363-32d60a31-ca5a-4871-8d1e-d53eb3f11332.png">|
|true|<img width="300" alt="origin-swt-enable-true dark" src="https://user-images.githubusercontent.com/6229653/163129354-4fda9fa3-b14a-46ff-9dbb-a3993ce9c7d3.png">|<img width="300" alt="hop-theme-enable-false dark" src="https://user-images.githubusercontent.com/6229653/163129369-d3072606-f4b5-4a28-a2a9-9f60ac94031d.png">|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org