You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/31 11:37:47 UTC

[GitHub] [skywalking-showcase] kezhenxu94 commented on a change in pull request #18: Add Satellite component and update the version of backend and ui

kezhenxu94 commented on a change in pull request #18:
URL: https://github.com/apache/skywalking-showcase/pull/18#discussion_r839503525



##########
File path: deploy/platform/docker/Makefile
##########
@@ -22,6 +22,11 @@ include Makefile.in
 features := $(subst $(comma), ,$(FEATURE_FLAGS))
 features := $(foreach f,$(features),-f docker-compose.$(f).yaml)
 
+BACKEND_ADDRESS := oap:11800

Review comment:
       1. `BACKEND_ADDRESS` contains the port

##########
File path: deploy/platform/kubernetes/Makefile.in
##########
@@ -21,4 +21,4 @@
 NAMESPACE ?= default
 AGENTLESS ?= false
 
-FEATURE_FLAGS ?= java-agent-injector,cluster,kubernetes-monitor,so11y,vm,als,event,istiod-monitor
\ No newline at end of file
+FEATURE_FLAGS ?= java-agent-injector,cluster,kubernetes-monitor,so11y,vm,als,event,istiod-monitor,satellite

Review comment:
       Please disable satellite by default

##########
File path: deploy/platform/kubernetes/Makefile
##########
@@ -22,6 +22,11 @@ include Makefile.in
 features := $(subst $(comma), ,$(FEATURE_FLAGS))
 features := $(foreach f,$(features),feature-$(f))
 
+BACKEND_SERVICE := oap
+ifneq (,$(findstring satellite,$(features)))
+	BACKEND_SERVICE := satellite
+endif

Review comment:
       2. `BACKEND_ADDRESS` doesn't contain the port, please make (1) and (2) consistent

##########
File path: deploy/platform/docker/Makefile.in
##########
@@ -17,4 +17,4 @@
 #
 
 .EXPORT_ALL_VARIABLES:
-FEATURE_FLAGS ?= agent,cluster,so11y,vm,event
+FEATURE_FLAGS ?= agent,cluster,so11y,vm,event,satellite

Review comment:
       Please disable satellite by default




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org