[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31593:
URL: https://github.com/apache/spark/pull/31593#discussion_r579979434



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
##########
@@ -64,8 +64,10 @@ final class DataStreamReader private[sql](sparkSession: SparkSession) extends Lo
    * @since 2.0.0
    */
   def schema(schema: StructType): DataStreamReader = {
-    val replaced = CharVarcharUtils.failIfHasCharVarchar(schema).asInstanceOf[StructType]
-    this.userSpecifiedSchema = Option(replaced)
+    if (schema != null) {
+      val replaced = CharVarcharUtils.failIfHasCharVarchar(schema).asInstanceOf[StructType]
+      this.userSpecifiedSchema = Option(replaced)
+    }

Review comment:
       Shall we change line 81~86 together?
   - https://github.com/apache/spark/pull/31593/files#diff-f53c71f87464270c195a2aa190bf2d3310e48e4e3f48cd6f6be5ba43f32f1422R81-R86




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org