You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/31 02:12:16 UTC
[kudu-CR](gh-pages) [gem] add dependency for date and fileutils gems
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14597
Change subject: [gem] add dependency for date and fileutils gems
......................................................................
[gem] add dependency for date and fileutils gems
Without these explicit dependencies, running 'site_tool proof'
was failing if running on Ubuntu 18.04.1 LTS.
Change-Id: I29e81e0a07fcd57b287dd55cda07c661a8b2f666
---
M Gemfile
M Gemfile.lock
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/14597/1
--
To view, visit http://gerrit.cloudera.org:8080/14597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29e81e0a07fcd57b287dd55cda07c661a8b2f666
Gerrit-Change-Number: 14597
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR](gh-pages) [gem] add dependency for date and fileutils gems
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14597 )
Change subject: [gem] add dependency for date and fileutils gems
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e81e0a07fcd57b287dd55cda07c661a8b2f666
Gerrit-Change-Number: 14597
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 02:12:49 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [gem] add dependency for date and fileutils gems
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14597 )
Change subject: [gem] add dependency for date and fileutils gems
......................................................................
[gem] add dependency for date and fileutils gems
Without these explicit dependencies, running 'site_tool proof'
was failing if running on Ubuntu 18.04.1 LTS.
Change-Id: I29e81e0a07fcd57b287dd55cda07c661a8b2f666
Reviewed-on: http://gerrit.cloudera.org:8080/14597
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M Gemfile
M Gemfile.lock
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I29e81e0a07fcd57b287dd55cda07c661a8b2f666
Gerrit-Change-Number: 14597
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>