You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/25 05:52:55 UTC

[GitHub] [incubator-mxnet] josephevans opened a new pull request #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.

josephevans opened a new pull request #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.
URL: https://github.com/apache/incubator-mxnet/pull/17437
 
 
   
   
   ## Description ##
   Our win CI scripts are failing on Windows 2019 Server. The newer PowerShell on this Win2019 Server gives a 'False' return code for the '$?' variable if any output is written to stderr, where previous versions did not. This PR changes the variable used for checking return code of last run program ($LastExitCode instead of $?).
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] larroy commented on issue #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.

Posted by GitBox <gi...@apache.org>.
larroy commented on issue #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.
URL: https://github.com/apache/incubator-mxnet/pull/17437#issuecomment-580495662
 
 
   @mxnet-label-bot add [pr-awaiting-merge]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] josephevans closed pull request #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.
URL: https://github.com/apache/incubator-mxnet/pull/17437
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu commented on issue #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.
URL: https://github.com/apache/incubator-mxnet/pull/17437#issuecomment-582039715
 
 
   @josephevans please resolve conflicts

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] josephevans commented on issue #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.

Posted by GitBox <gi...@apache.org>.
josephevans commented on issue #17437: Update Win CI scripts to use syntax compatible with Win2019 server PS.
URL: https://github.com/apache/incubator-mxnet/pull/17437#issuecomment-580487953
 
 
   > Do you think it makes sense to use Check-call like in the other scripts for consistency here?
   > 
   > https://github.com/aiengines/ci/blob/master/windows/setup.ps1#L21
   
   This does effectively the same thing without having to copy the function to every file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services