You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "utkarsharma2 (via GitHub)" <gi...@apache.org> on 2023/09/27 06:28:04 UTC
[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #34640: Standardise output of "airflow connections export" to those of "airflow variables export" and "airflow users export"
utkarsharma2 commented on code in PR #34640:
URL: https://github.com/apache/airflow/pull/34640#discussion_r1338100162
##########
airflow/cli/commands/connection_command.py:
##########
@@ -197,9 +197,9 @@ def connections_export(args):
f.write(msg)
if file_is_stdout:
- print("\nConnections successfully exported.", file=sys.stderr)
+ print(f"\n{len(connections)} connections successfully exported.", file=sys.stderr)
Review Comment:
@Jayden-Chiu Not a blocker, How can we ensure that the output of `export connection` `export variable` and `users export` doesn't mismatch by any further changes in the codebase?
Can we add a single function to prepare a similar output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org