[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6924: Implement getRecord for immutableSegmentImpl

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #6924:
URL: https://github.com/apache/incubator-pinot/pull/6924#discussion_r632858728



##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java
##########
@@ -171,7 +172,14 @@ public ValidDocIndexReader getValidDocIndex() {
   @Override
   public GenericRow getRecord(int docId, GenericRow reuse) {
     // NOTE: Use PinotSegmentRecordReader to read immutable segment
-    throw new UnsupportedOperationException();
+    try {
+      PinotSegmentRecordReader pinotSegmentRecordReader = new PinotSegmentRecordReader(this);

Review comment:
       I don't think we should instantiate a record reader from the segment and too per call




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org