You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Fabian Hueske <fh...@gmail.com> on 2015/06/05 10:13:07 UTC
[DISCUSS] TableAPI renaming toTable
Hi folks,
I thought about renaming the TableEnvironment.toTable() method to
TableEnvironment.fromDataSet().
This would be closer to SQL FROM and allow to add other methods like
fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
If we decide for the renaming, we should do it before the release.
Cheers, Fabian
Re: [DISCUSS] TableAPI renaming toTable
Posted by Fabian Hueske <fh...@gmail.com>.
Thanks everybody,
I will prepare a PR for that.
2015-06-05 10:45 GMT+02:00 Stephan Ewen <se...@apache.org>:
> Great!
>
> On Fri, Jun 5, 2015 at 10:24 AM, Aljoscha Krettek <al...@apache.org>
> wrote:
>
> > Of course, everything that doesn't need windows is supported.
> >
> > On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger <rm...@apache.org>
> > wrote:
> > > +1
> > >
> > > I didn't know that the Table API supports DataStreams as well.
> > >
> > > On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <aljoscha@apache.org
> >
> > > wrote:
> > >
> > >> +1, then we would of course also rename the other one to
> > "fromDataStream".
> > >>
> > >> On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <fh...@gmail.com>
> > wrote:
> > >> > Hi folks,
> > >> >
> > >> > I thought about renaming the TableEnvironment.toTable() method to
> > >> > TableEnvironment.fromDataSet().
> > >> > This would be closer to SQL FROM and allow to add other methods like
> > >> > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
> > >> >
> > >> > If we decide for the renaming, we should do it before the release.
> > >> >
> > >> > Cheers, Fabian
> > >>
> >
>
Re: [DISCUSS] TableAPI renaming toTable
Posted by Stephan Ewen <se...@apache.org>.
Great!
On Fri, Jun 5, 2015 at 10:24 AM, Aljoscha Krettek <al...@apache.org>
wrote:
> Of course, everything that doesn't need windows is supported.
>
> On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger <rm...@apache.org>
> wrote:
> > +1
> >
> > I didn't know that the Table API supports DataStreams as well.
> >
> > On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <al...@apache.org>
> > wrote:
> >
> >> +1, then we would of course also rename the other one to
> "fromDataStream".
> >>
> >> On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <fh...@gmail.com>
> wrote:
> >> > Hi folks,
> >> >
> >> > I thought about renaming the TableEnvironment.toTable() method to
> >> > TableEnvironment.fromDataSet().
> >> > This would be closer to SQL FROM and allow to add other methods like
> >> > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
> >> >
> >> > If we decide for the renaming, we should do it before the release.
> >> >
> >> > Cheers, Fabian
> >>
>
Re: [DISCUSS] TableAPI renaming toTable
Posted by Aljoscha Krettek <al...@apache.org>.
Of course, everything that doesn't need windows is supported.
On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger <rm...@apache.org> wrote:
> +1
>
> I didn't know that the Table API supports DataStreams as well.
>
> On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <al...@apache.org>
> wrote:
>
>> +1, then we would of course also rename the other one to "fromDataStream".
>>
>> On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <fh...@gmail.com> wrote:
>> > Hi folks,
>> >
>> > I thought about renaming the TableEnvironment.toTable() method to
>> > TableEnvironment.fromDataSet().
>> > This would be closer to SQL FROM and allow to add other methods like
>> > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
>> >
>> > If we decide for the renaming, we should do it before the release.
>> >
>> > Cheers, Fabian
>>
Re: [DISCUSS] TableAPI renaming toTable
Posted by Robert Metzger <rm...@apache.org>.
+1
I didn't know that the Table API supports DataStreams as well.
On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <al...@apache.org>
wrote:
> +1, then we would of course also rename the other one to "fromDataStream".
>
> On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <fh...@gmail.com> wrote:
> > Hi folks,
> >
> > I thought about renaming the TableEnvironment.toTable() method to
> > TableEnvironment.fromDataSet().
> > This would be closer to SQL FROM and allow to add other methods like
> > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
> >
> > If we decide for the renaming, we should do it before the release.
> >
> > Cheers, Fabian
>
Re: [DISCUSS] TableAPI renaming toTable
Posted by Aljoscha Krettek <al...@apache.org>.
+1, then we would of course also rename the other one to "fromDataStream".
On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <fh...@gmail.com> wrote:
> Hi folks,
>
> I thought about renaming the TableEnvironment.toTable() method to
> TableEnvironment.fromDataSet().
> This would be closer to SQL FROM and allow to add other methods like
> fromCSV(), fromHCat(), fromParquet(), fromORC(), etc.
>
> If we decide for the renaming, we should do it before the release.
>
> Cheers, Fabian