You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org> on 2014/12/08 19:39:13 UTC

[jira] [Commented] (SQOOP-1858) Sqoop2: Print out warnings from git apply on output of precommit hook

    [ https://issues.apache.org/jira/browse/SQOOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238218#comment-14238218 ] 

Jarek Jarcec Cecho commented on SQOOP-1858:
-------------------------------------------

Example outputs are available on SQOOP-1781.

> Sqoop2: Print out warnings from git apply on output of precommit hook
> ---------------------------------------------------------------------
>
>                 Key: SQOOP-1858
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1858
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.4
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1858.patch
>
>
> Currently we only check the return value of executing {{git apply}} and printing it's stdin/stderr only if the return is not 0. However having warnings (for example trailing whitespace) won't change the return value and hence those get silently ignored. Hence I would suggest to enhance the precommit hook to print out the output {{git apply}} in case that it's not empty to highlight the warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)