You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2012/07/15 18:05:37 UTC
svn commit: r1361720 - /commons/proper/collections/trunk/checkstyle.xml
Author: tn
Date: Sun Jul 15 16:05:36 2012
New Revision: 1361720
URL: http://svn.apache.org/viewvc?rev=1361720&view=rev
Log:
Add more checks to checkstyle.xml
Modified:
commons/proper/collections/trunk/checkstyle.xml
Modified: commons/proper/collections/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/checkstyle.xml?rev=1361720&r1=1361719&r2=1361720&view=diff
==============================================================================
--- commons/proper/collections/trunk/checkstyle.xml (original)
+++ commons/proper/collections/trunk/checkstyle.xml Sun Jul 15 16:05:36 2012
@@ -1,20 +1,14 @@
<?xml version="1.0"?>
-<!--
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to You under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
--->
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ You under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.1//EN"
@@ -22,26 +16,60 @@ limitations under the License.
<!-- commons lang customization of default Checkstyle behavior -->
<module name="Checker">
- <property name="localeLanguage" value="en"/>
- <module name="JavadocPackage">
- <property name="allowLegacy" value="true"/>
- </module>
- <module name="FileTabCharacter"/>
- <module name="TreeWalker">
- <module name="AvoidStarImport"/>
- <module name="RedundantImport"/>
- <module name="UnusedImports"/>
- <module name="NeedBraces"/>
- <module name="RedundantThrows">
- <property name="allowUnchecked" value="true"/>
- </module>
- <module name="LineLength">
- <property name="max" value="120"/>
- </module>
- <module name="JavadocMethod">
- <property name="allowUndeclaredRTE" value="true"/>
- </module>
- </module>
+ <property name="localeLanguage" value="en" />
+ <property name="severity" value="warning" />
+
+ <module name="JavadocPackage">
+ <property name="allowLegacy" value="true" />
+ </module>
+
+ <!-- No tabs allowed! -->
+ <module name="FileTabCharacter" />
+
+ <!-- Require files to end with newline characters -->
+ <module name="NewlineAtEndOfFile"/>
+
+ <module name="TreeWalker">
+ <module name="AvoidStarImport" />
+ <module name="RedundantImport" />
+ <module name="UnusedImports" />
+ <module name="NeedBraces" />
+ <module name="RedundantThrows">
+ <property name="allowUnchecked" value="true" />
+ </module>
+ <module name="LineLength">
+ <property name="max" value="120" />
+ </module>
+
+ <!-- Must have class / interface header comments including scm version -->
+ <!-- Disable by now as it also enforces generic type parameters in type javadoc -->
+<!-- <module name="JavadocType"> -->
+<!-- <property name="versionFormat" value="\$Id.*\$"/> -->
+<!-- </module> -->
+
+ <!-- Require method javadocs, allow undeclared RTE -->
+ <module name="JavadocMethod">
+ <property name="allowUndeclaredRTE" value="true" />
+ </module>
+
+ <!-- Require hash code override when equals is -->
+ <module name="EqualsHashCode" />
+
+ <!-- Switch statements should be complete and with independent cases -->
+ <module name="FallThrough" />
+ <module name="MissingSwitchDefault" />
+
+ <!-- Constant names should obey the traditional all uppercase naming convention -->
+ <module name="ConstantName" />
+
+ <!-- Authors should be in pom.xml file -->
+ <module name="Regexp">
+ <property name="format" value="@author"/>
+ <property name="illegalPattern" value="true"/>
+ <property name="message" value="developers names should be in pom file"/>
+ </module>
+
+ </module>
</module>