[jira] [Commented] (CB-14242) Remove bundledDependencies & committed node_modules from cordova-ios

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566353#comment-16566353 ] 

ASF GitHub Bot commented on CB-14242:
-------------------------------------

brodybits opened a new pull request #388: CB-14242 remove bundledDependencies and committed node_modules
URL: https://github.com/apache/cordova-ios/pull/388
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### What does this PR do?
   
   See <https://issues.apache.org/jira/browse/CB-14242>:
   
   - remove `bundledDependencies` entry from `package.json`
   - completely remove committed `node_modules`
   - fix `.gitignore` to completely ignore `node_modules`
   
   ### Suggested merge type
   
   - rebase or merge commit
   
   I would personally favor rebase merge: would be much cleaner for limited number of commits.
   
   Squash merge is not desired since one of the commits is extremely large.
   
   ### What testing has been done on this change?
   
   - [ ] able to do `cordova platform add brodybits/cordova-ios#cb-14242-remove-bundled-dependencies-and-node-modules` on new Cordova project and run on iOS using Cordova CLI
   - [ ] check that `npm test` items pass on Travis CI
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - ~~Added automated test coverage as appropriate for this change.``

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove bundledDependencies & committed node_modules from cordova-ios
> --------------------------------------------------------------------
>
>                 Key: CB-14242
>                 URL: https://issues.apache.org/jira/browse/CB-14242
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: cordova-ios
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> As described in parent task CB-14241: now that next major "-dev" release is marked (cordova-ios@5.0.0-dev) and CB-14074 (remove Node.js 4 from cordova-ios package.json & CI) is committed it is time to:
>  * remove {{bundledDependencies}} entry from {{package.json}}
>  * remove the committed {{node_modules}}
>  * fix {{.gitignore}} to completely ignore {{node_modules}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org