You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2010/12/04 23:23:10 UTC
[jira] Issue Comment Edited: (LUCENE-2799) MMapDirectory not
designed for inheritance
[ https://issues.apache.org/jira/browse/LUCENE-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966864#action_12966864 ]
Uwe Schindler edited comment on LUCENE-2799 at 12/4/10 5:22 PM:
----------------------------------------------------------------
To change the openInput logic to map special files to other directories use e.g. FileSwitchDirectory or similar implementations with the delegation pattern. There is no need to extend MMapDirectory.
was (Author: thetaphi):
To change the openIngs logic to map special files to other directories use e.g. FileSwitchDirectory or similar implementations sign the delegate pattern. There is no need to extend MMapDirectory.
> MMapDirectory not designed for inheritance
> ------------------------------------------
>
> Key: LUCENE-2799
> URL: https://issues.apache.org/jira/browse/LUCENE-2799
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Affects Versions: 3.0.3
> Reporter: René Treffer
>
> How to reproduce
> Try to inherit from MMapDirectory to change the openInput logic (open files from different directories).
> Expected result:
> Inherit from MMapDirectory, overwrite the one method, done.
> Actual result:
> It's impossible to overwrite the method as the inner classes would be missing. It's impossible to fork the inner classes as they depend on a final method with default visibility (cleanMapping).
> It turns out to be the easiest option to completely for the code and replace just the method in question.
> Possible fix:
> Change the visibility of most members and subtypes to be at least protected and avoid the default visibility.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org