You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Kohei Nozaki (JIRA)" <ji...@apache.org> on 2015/05/02 11:40:07 UTC
[jira] [Updated] (ROL-2073) Move hard-coded date / timestamp
formatting to ApplicationResources
[ https://issues.apache.org/jira/browse/ROL-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kohei Nozaki updated ROL-2073:
------------------------------
Attachment: ROL-2073-update1.patch
Glen, thanks for the comment. I have done the changes in following pages/parts but left sentences such as "Posted by .... at .... in category ...." as is.
* Caption of calendar
* Standard themes
* Administration pages
** Entries.jsp
** Comments.jsp
** EntryEdit.jsp
Note that this change won't make any affect to English-only users. it's just for multi-language users.
> Move hard-coded date / timestamp formatting to ApplicationResources
> -------------------------------------------------------------------
>
> Key: ROL-2073
> URL: https://issues.apache.org/jira/browse/ROL-2073
> Project: Apache Roller
> Issue Type: Improvement
> Components: Themes and Macros
> Affects Versions: 5.1.2
> Reporter: Kohei Nozaki
> Assignee: Roller Unassigned
> Priority: Trivial
> Attachments: ROL-2073-update1.patch, ROL-2073.patch
>
>
> There're some hard-coded date / timestamp formatting as follows:
> In {{_day.vm}} or {{day.vm}} of templates:
> {noformat}
> $utils.formatDate($day, "EEEE MMM dd, yyyy")
> $utils.formatDate($entry.pubTime, "hh:mma MMM dd, yyyy")
> {noformat}
> In {{CalendarTag#doStartTag()}}:
> {noformat}
> // formatter Month-Year title of calendar
> SimpleDateFormat formatTitle = new SimpleDateFormat("MMMM yyyy", mLocale);
> {noformat}
> In Japanese locale, it produces following expressions:
> # 水曜日 4 22, 2015
> # Posted at 02:15午後 4 22, 2015 by kyle in Technology | 投稿されたコメント [0]
> # 4月 2015
> They looks pretty weird to Japanese people. I think Japanese people prefer following expressions instead:
> # 2015年4月22日 (水)
> # Posted at 2015年4月22日 午後 02:15 (this may better to move the fragment entirely, not only the date, but it might be too much for default templates)
> # 2015年4月
> And I think these strange expressions may effect badly to first impression of Japanese people who just installed Roller so give it a try. so I'd like to move these expressions to ApplicationResources so that allow templates to show locale specific expressions. any thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)