You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/11 15:51:32 UTC

[GitHub] [pulsar-manager] eolivelli opened a new pull request #300: Deploy BKVM.org - BookKeeper Visual Manager

eolivelli opened a new pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300


   - add dependency to bkvn.org war
   - make explicit a few dependencies
   - start bkvm.org on backend service at path http://localhost:8080/bkvm
   - create example bkvm.conf file
   
   
   This is only a POC, it needs BKVM 1.1.1 that has not been released
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli closed pull request #300: Bundle BKVM.org - BookKeeper Visual Manager 1.2.0

Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli commented on pull request #300: Deploy BKVM.org - BookKeeper Visual Manager

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#issuecomment-648769807


   @tuteng I will try to finish this work by the end of the week
   
   @mino181295 we need a release of BKVM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] tuteng commented on a change in pull request #300: Deploy BKVM.org - BookKeeper Visual Manager

Posted by GitBox <gi...@apache.org>.
tuteng commented on a change in pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#discussion_r444800993



##########
File path: src/main/resources/application.properties
##########
@@ -13,7 +13,7 @@
 #
 
 spring.cloud.refresh.refreshable=none
-server.port=7750
+server.port=8080

Review comment:
       Shall we consider changing a port? The port 8080 is easy to cause port conflict?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] tuteng merged pull request #300: Bundle BKVM.org - BookKeeper Visual Manager 1.2.0

Posted by GitBox <gi...@apache.org>.
tuteng merged pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli commented on pull request #300: Bundle BKVM.org - BookKeeper Visual Manager 1.2.0

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#issuecomment-648821854


   @rdhabalia  @sijie  @tuteng patch is ready for review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli commented on a change in pull request #300: Deploy BKVM.org - BookKeeper Visual Manager

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#discussion_r444794869



##########
File path: src/main/resources/application.properties
##########
@@ -13,7 +13,7 @@
 #
 
 spring.cloud.refresh.refreshable=none
-server.port=7750
+server.port=8080

Review comment:
       This change is needed for running Pulsar Manager only using the Java Backend Service.
   But we can leave 7750 by now and have a configuration guide




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli removed a comment on pull request #300: Bundle BKVM.org - BookKeeper Visual Manager 1.2.0

Posted by GitBox <gi...@apache.org>.
eolivelli removed a comment on pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#issuecomment-648801884


   @tuteng  Travis will pass once BKVM 1.2.0 is Available to Maven Central mirrors


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli commented on a change in pull request #300: Deploy BKVM.org - BookKeeper Visual Manager

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#discussion_r444832667



##########
File path: src/main/resources/application.properties
##########
@@ -13,7 +13,7 @@
 #
 
 spring.cloud.refresh.refreshable=none
-server.port=7750
+server.port=8080

Review comment:
       To me another port will be okay.
   Please check that port 8080 is required below at zuul.routes.admin.url
   
   I suggest using 8888.
   I don't know the amount of changes needed to the docs and docker files
   
   if we move forward with bundling the front-end with the back-end than docker files will be far easier (no need for nginx)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli commented on pull request #300: Deploy BKVM.org - BookKeeper Visual Manager

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#issuecomment-648801884


   @tuteng  Travis will pass once BK 1.2.0 is Available to Maven Central mirrors


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] eolivelli edited a comment on pull request #300: Deploy BKVM.org - BookKeeper Visual Manager

Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #300:
URL: https://github.com/apache/pulsar-manager/pull/300#issuecomment-648801884


   @tuteng  Travis will pass once BKVM 1.2.0 is Available to Maven Central mirrors


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org