You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kevingurney (via GitHub)" <gi...@apache.org> on 2023/07/07 14:15:42 UTC

[GitHub] [arrow] kevingurney opened a new pull request, #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

kevingurney opened a new pull request, #36549:
URL: https://github.com/apache/arrow/pull/36549

   Follow up to https://github.com/apache/arrow/issues/36474#issuecomment-1623128986.
   
   Marking this as MINOR following https://github.com/apache/arrow/pull/36504 and https://github.com/apache/arrow/pull/36468.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney merged pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #36549:
URL: https://github.com/apache/arrow/pull/36549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1625696461

   @raulcd - I noticed that after merging in this PR using the GitHub UI, that the commit message doesn't have "Authored-by" or "Signed-off-by" like other commits do. Is this something that should be added manually to the commit message when squashing?
   
   I looked through the development documentation for information on this topic, but couldn't seem to find anything. I recall that there are some automated scripts that get run during PR merging that add things like "Co-authored-by" when there are commits from multiple authors associated with a PR, but I'm not sure about "Signed-off-by".
   
   I apologize for my lack of knowledge on this topic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1626403004

   I did a quick search online about ways to disable the green merge button in the UI to prevent others from accidentally making the same mistake in the future. Unfortunately, it seems like there isn't an easy way to do this.
   
   There do appear to be a few "workarounds" suggested online (e.g. [this article](https://www.jessesquires.com/blog/2021/08/24/useful-label-based-github-actions-workflows/#do-not-merge)), such as creating a CI workflow that will unconditionally fail if a certain label is present on the PR. However, this has the major downside that the default PR CI status would always include a failing workflow, which does not feel ideal.
   
   Perhaps, a more straightforward solution would be to create some kind of "Getting Started as a Committer" guide (or something to that effect), with https://github.com/apache/arrow/blob/41e08795864b96f8fbbc9c42975d82e3bb0bb6d1/dev/README.md#how-to-merge-a-pull-request included as "required reading".
   
   If that sounds helpful, I could follow up with a PR for that and work with other community members to ensure that it contains any other important references and is included in any materials that are shared with new committers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney commented on a diff in pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #36549:
URL: https://github.com/apache/arrow/pull/36549#discussion_r1256042404


##########
.github/CODEOWNERS:
##########
@@ -42,7 +42,7 @@
 /go/ @zeroshade
 /java/ @lidavidm
 /js/ @domoritz @trxcllnt
-/matlab/ @assignUser
+/matlab/ @assignUser @kevingurney

Review Comment:
   Thank you, @assignUser! :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1632787648

   For reference, I captured the idea of creating a "New Committer Guide" in #36644.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1625666151

   @raulcd - sure! I'll merge this in. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] westonpace commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1632876642

   That's a great idea.  If it's any consolation [I did an accidental push-to-main within a month of getting write privileges](https://lists.apache.org/list?dev@arrow.apache.org:lte=3y:force%20push%20accidental%20commit) :laughing: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1636701755

   Conbench analyzed the 6 benchmark runs on commit `ac523fed`.
   
   There were 4 benchmark results indicating a performance regression:
   
   - Commit Run on `arm64-m6g-linux-compute` at [2023-07-07 20:22:16Z](http://conbench.ursa.dev/compare/runs/b026b09cd6044f31a6654b066deb45ee...348ffdce981a46eeb71ac03528584fa5/)
     - [params=<STATIC_VECTOR(int)>, source=cpp-micro, suite=arrow-small-vector-benchmark](http://conbench.ursa.dev/compare/benchmarks/064a83db6c1c700a8000896c8ffe5487...064a874558b7730c800070b63a5ba215)
     - [engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-03, scale_factor=10](http://conbench.ursa.dev/compare/benchmarks/064a84b0115e757380001a077da302e1...064a87fc72847c6080000ebc5b3ff494)
   - and 2 more (see the report linked below)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/15064322668) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] assignUser commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1633400047

   Hm as we now use the api to merge we can probably use the protected branches feature mentioned in the thread? Thanks for sharing :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] assignUser commented on a diff in pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36549:
URL: https://github.com/apache/arrow/pull/36549#discussion_r1255945619


##########
.github/CODEOWNERS:
##########
@@ -42,7 +42,7 @@
 /go/ @zeroshade
 /java/ @lidavidm
 /js/ @domoritz @trxcllnt
-/matlab/ @assignUser
+/matlab/ @assignUser @kevingurney

Review Comment:
   ```suggestion
   /matlab/ @kevingurney
   ```
   As I only added myself to catch any stray matlab PRs that need you tagged on I can now be removed, congrats again!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] assignUser commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1626199973

   Ah we don't use the ui to merge (for a number of reasons of technical/historic reasons), the merge script creates the standardized commit message etc. see https://github.com/apache/arrow/blob/41e08795864b96f8fbbc9c42975d82e3bb0bb6d1/dev/README.md#how-to-merge-a-pull-request
   
   Shouldn't be an issue with minor PR so don't worry!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney commented on pull request #36549: MINOR: [Dev] Add kevingurney to CODEOWNERS for `/matlab/`

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #36549:
URL: https://github.com/apache/arrow/pull/36549#issuecomment-1626393086

   Ah, I am very sorry about the oversight on my part! I'm not sure how I missed that documentation. I'll be sure to use the merge script in the future. Thank you for helping clear this up for me!
   
   My sincere apologies again for merging this PR incorrectly!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org