You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/05/23 09:42:42 UTC
[GitHub] [incubator-linkis] Alexkun opened a new pull request, #2159: EC logs need to support rolling
Alexkun opened a new pull request, #2159:
URL: https://github.com/apache/incubator-linkis/pull/2159
### What is the purpose of the change
#2076
### Brief change log
(for example:)
- All ECs add support for rolling log
### Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)
- Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- Anything that affects deployment: (no)
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2159: EC logs need to support rolling
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2159:
URL: https://github.com/apache/incubator-linkis/pull/2159#issuecomment-1134473568
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2159?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2159](https://codecov.io/gh/apache/incubator-linkis/pull/2159?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fafbee) into [dev-1.1.3](https://codecov.io/gh/apache/incubator-linkis/commit/c953223afe1b80df8074dae7355a4cba6f0c8285?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c953223) will **increase** coverage by `1.16%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.1.3 #2159 +/- ##
===============================================
+ Coverage 18.45% 19.61% +1.16%
- Complexity 703 843 +140
===============================================
Files 344 383 +39
Lines 10723 11820 +1097
Branches 1608 1757 +149
===============================================
+ Hits 1979 2319 +340
- Misses 8539 9258 +719
- Partials 205 243 +38
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/linkis/jobhistory/util/QueryUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWpvYmhpc3Rvcnkvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvam9iaGlzdG9yeS91dGlsL1F1ZXJ5VXRpbHMuc2NhbGE=) | `17.64% <0.00%> (-0.27%)` | :arrow_down: |
| [...ava/org/apache/linkis/variable/entity/VarTree.java](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLXZhcmlhYmxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvdmFyaWFibGUvZW50aXR5L1ZhclRyZWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...onfiguration/exception/ConfigurationException.java](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jb25maWd1cmF0aW9uL2V4Y2VwdGlvbi9Db25maWd1cmF0aW9uRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../linkis/configuration/validate/NoneValidator.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvY29uZmlndXJhdGlvbi92YWxpZGF0ZS9Ob25lVmFsaWRhdG9yLnNjYWxh) | `66.66% <0.00%> (ø)` | |
| [...ava/org/apache/linkis/variable/util/Constants.java](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLXZhcmlhYmxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvdmFyaWFibGUvdXRpbC9Db25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/linkis/variable/entity/VarKeyUser.java](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLXZhcmlhYmxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvdmFyaWFibGUvZW50aXR5L1ZhcktleVVzZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...nkis/configuration/validate/ContainValidator.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvY29uZmlndXJhdGlvbi92YWxpZGF0ZS9Db250YWluVmFsaWRhdG9yLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...apache/linkis/configuration/entity/ConfigTree.java](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jb25maWd1cmF0aW9uL2VudGl0eS9Db25maWdUcmVlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pache/linkis/configuration/util/JsonNodeUtil.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvY29uZmlndXJhdGlvbi91dGlsL0pzb25Ob2RlVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...linkis/configuration/validate/OneOfValidator.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvY29uZmlndXJhdGlvbi92YWxpZGF0ZS9PbmVPZlZhbGlkYXRvci5zY2FsYQ==) | `50.00% <0.00%> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/incubator-linkis/pull/2159/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2159?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2159?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c953223...1fafbee](https://codecov.io/gh/apache/incubator-linkis/pull/2159?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong closed pull request #2159: EC logs need to support rolling
Posted by GitBox <gi...@apache.org>.
peacewong closed pull request #2159: EC logs need to support rolling
URL: https://github.com/apache/incubator-linkis/pull/2159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #2159: EC logs need to support rolling
Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2159:
URL: https://github.com/apache/incubator-linkis/pull/2159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org