[GitHub] [hive] zhangbutao commented on a diff in pull request #4185: HIVE-27208: Iceberg: Add support for rename table.

["zhangbutao (via GitHub)" <gi...@apache.org>]

zhangbutao commented on code in PR #4185:
URL: https://github.com/apache/hive/pull/4185#discussion_r1155411085


##########
iceberg/iceberg-handler/src/test/queries/positive/iceberg_rename.q:
##########
@@ -0,0 +1,48 @@
+
+-- create an unpartitioned table
+create table iceorgin (id int, name string) Stored by Iceberg TBLPROPERTIES ('format-version'='2');
+
+-- insert some values
+insert into iceorgin values (1, 'ABC'),(2, 'CBS'),(3, null),(4, 'POPI'),(5, 'AQWR'),(6, 'POIU'),
+(9, null),(8,'POIKL'),(10, 'YUIO');
+
+-- do some deletes
+delete from iceorgin where id>9 OR id=8;
+
+select * from iceorgin order by id;
+
+-- do the rename
+
+alter table iceorgin rename to icerenamed;
+
+select * from icerenamed order by id;
+
+-- create a partitioned table
+create table iceorginpart (id int) partitioned by (part string) Stored by Iceberg TBLPROPERTIES ('format-version'='2');

Review Comment:
   If i am understand correctly, i don't think only v2 table support rename operation. This qtest will mislead user that only v2 table can do rename operation, Actually, It shoud be have nothing to do with format-version. Should we also add v1 table qtest?
   Please correct me if am wrong. Thx.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org