You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/24 13:12:45 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5554: Add kafka config for how long does kafka query server topic will trigger timeout

wu-sheng commented on a change in pull request #5554:
URL: https://github.com/apache/skywalking/pull/5554#discussion_r494304985



##########
File path: apm-sniffer/optional-reporter-plugins/kafka-reporter-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
##########
@@ -42,6 +46,8 @@
 
     private KafkaProducer<String, Bytes> producer;
 
+    private static final ILog LOGGER = LogManager.getLogger(KafkaProducerManager.class);

Review comment:
       The static field should be on the top.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org