[GitHub] rahul003 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr

[GitBox <gi...@apache.org>]

rahul003 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr
URL: https://github.com/apache/incubator-mxnet/pull/8938#discussion_r154817984
 
 

 ##########
 File path: benchmark/python/sparse/dot.py
 ##########
 @@ -337,27 +340,41 @@ def print_benchmark_info(lhs, rhs, lhs_trans, fw):
 
     def run_benchmark(ctx=None, lhs="csr", lhs_trans=False, rhs="dns", fw="mxnet", rhs_density=1,
                       distribution="uniform"):
-        if lhs != "csr":
-            raise ValueError("Value other than csr for lhs not supported")
+
         if rhs_density > 1 or rhs_density < 0:
-            raise ValueError("rhs_density has to be between 0 and 1")
+            raise ValueError("Value other than csr for lhs not supported")
 
 Review comment:
   The check and the error statement don't seem to match?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services