[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813007#comment-17813007 ] 

ASF subversion and git services commented on TAP5-2769:
-------------------------------------------------------

Commit fa1b44e79b23c5774eb800976996ffa36ac3c06a in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=fa1b44e79 ]

TAP5-2769: fixing hardcoded references to ASM packages

> Upgrade ASM to 9.6 to allow running on Java 21
> ----------------------------------------------
>
>                 Key: TAP5-2769
>                 URL: https://issues.apache.org/jira/browse/TAP5-2769
>             Project: Tapestry 5
>          Issue Type: Task
>          Components: plastic
>    Affects Versions: 5.8.3
>            Reporter: Chris Poulsen
>            Assignee: Thiago Henrique De Paula Figueiredo
>            Priority: Major
>             Fix For: 5.8.4
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access the static package protected method 
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46



--
This message was sent by Atlassian Jira
(v8.20.10#820010)