You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/25 23:56:05 UTC
Review Request 38776: Removed unnecessary close calls on ifstream and
ofstream.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38776/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
std::ifstream and std::ofstream have RAII semantics and will close() upon destruction.
Diffs
-----
src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
src/log/tool/benchmark.cpp 4895dd8812954939bbef4eb8bbba20cfbde592f9
Diff: https://reviews.apache.org/r/38776/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38776: Removed unnecessary close calls on ifstream
and ofstream.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38776/#review100707
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38775, 38776]
All tests passed.
- Mesos ReviewBot
On Sept. 25, 2015, 9:56 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38776/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 9:56 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> std::ifstream and std::ofstream have RAII semantics and will close() upon destruction.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
> src/log/tool/benchmark.cpp 4895dd8812954939bbef4eb8bbba20cfbde592f9
>
> Diff: https://reviews.apache.org/r/38776/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38776: Removed unnecessary close calls on ifstream
and ofstream.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38776/#review100694
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 25, 2015, 9:56 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38776/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 9:56 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> std::ifstream and std::ofstream have RAII semantics and will close() upon destruction.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
> src/log/tool/benchmark.cpp 4895dd8812954939bbef4eb8bbba20cfbde592f9
>
> Diff: https://reviews.apache.org/r/38776/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>