You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/26 09:52:17 UTC
[GitHub] [incubator-seatunnel] wuzhenhua01 opened a new pull request, #1751: [Feature][seatunnel-transforms] Add Replace transforms for spark #1750
wuzhenhua01 opened a new pull request, #1751:
URL: https://github.com/apache/incubator-seatunnel/pull/1751
Add replace transform for spark https://github.com/apache/incubator-seatunnel/issues/1750
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1751: [Feature][seatunnel-transforms] Add Replace transforms for spark #1750
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1751:
URL: https://github.com/apache/incubator-seatunnel/pull/1751#discussion_r858911067
##########
seatunnel-transforms/seatunnel-transforms-spark/seatunnel-transform-spark-replace/src/main/resources/MeTA-INF.services/org.apache.seatunnel.spark.BaseSparkTransform:
##########
@@ -0,0 +1,18 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+org.apache.seatunnel.spark.transform.Sql
Review Comment:
This should be your plugin class name.
```suggestion
org.apache.seatunnel.spark.transform.Replace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuzhenhua01 commented on pull request #1751: [Feature][seatunnel-transforms] Add Replace transforms for spark #1750
Posted by GitBox <gi...@apache.org>.
wuzhenhua01 commented on PR #1751:
URL: https://github.com/apache/incubator-seatunnel/pull/1751#issuecomment-1110673531
@ruanwenjun I've updated the doc for spark replace transforms. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1751: [Feature][seatunnel-transforms] Add Replace transforms for spark #1750
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1751:
URL: https://github.com/apache/incubator-seatunnel/pull/1751#issuecomment-1110585499
@wuzhenhua01 Please add doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuzhenhua01 commented on pull request #1751: [Feature][seatunnel-transforms] Add Replace transforms for spark #1750
Posted by GitBox <gi...@apache.org>.
wuzhenhua01 commented on PR #1751:
URL: https://github.com/apache/incubator-seatunnel/pull/1751#issuecomment-1110433998
Thanks @ruanwenjun for your review. I've updated the code based on your recommendations. Please let me know if there is any additional advice. Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1751: [Feature][seatunnel-transforms] Add Replace transforms for spark #1750
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1751:
URL: https://github.com/apache/incubator-seatunnel/pull/1751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org