[GitHub] [accumulo] jmark99 commented on a change in pull request #2551: Add compareTo method to HostAndPort class

[GitBox <gi...@apache.org>]

jmark99 commented on a change in pull request #2551:
URL: https://github.com/apache/accumulo/pull/2551#discussion_r822034570



##########
File path: core/src/main/java/org/apache/accumulo/core/util/HostAndPort.java
##########
@@ -281,4 +282,13 @@ public int getPortOrDefault(int defaultPort) {
     return hasPort() ? port : defaultPort;
   }
 
+  /**
+   * HostAndPort must implement compareTo. As this is a seldom used utiltiy, compareTo simply treats
+   * HostAndPort values as Strings.
+   */
+  @Override
+  public int compareTo(HostAndPort other) {
+    return Comparator.nullsFirst(Comparator.comparing(HostAndPort::toString)).compare(this, other);

Review comment:
       I added a couple of new test cases to verify that the HostAndPort class handles padded port values.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org