You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ni...@apache.org on 2014/02/09 20:03:24 UTC
svn commit: r1566354 - /logging/log4j/log4j2/tags/log4j-2.0-rc1/
Author: nickwilliams
Date: Sun Feb 9 19:03:23 2014
New Revision: 1566354
URL: http://svn.apache.org/r1566354
Log:
[maven-release-plugin] copy for tag log4j-2.0-rc1
Added:
logging/log4j/log4j2/tags/log4j-2.0-rc1/
- copied from r1566353, logging/log4j/log4j2/trunk/
Re: svn commit: r1566354 - /logging/log4j/log4j2/tags/log4j-2.0-rc1/
Posted by Nick Williams <ni...@nicholaswilliams.net>.
Furthermore, I'm doing this like the Wiki (https://wiki.apache.org/logging/Log4j2ReleaseGuide) says:
If the release fails after sending the vote email:
...
2. Rename the release tag in subversion to add rcn to the end of the tag.
Nick
On Feb 9, 2014, at 1:22 PM, Nick Williams wrote:
> That is not how we have done it in the past. We have never done it that way. When releasing beta8, we originally created the tag log4j-2.0-beta8. When the vote failed, we renamed that tag to log4j-2.0-beta8-rc1 and re-created the tag log4j-2.0-beta8. The vote on that tag passed. This is clearly shown in the source control log:
>
> - /logging/log4j/log4j2/tags/log4j-2.0-beta8-rc1 was copied from /logging/log4j/log4j2/tags/log4j-2.0-beta8 in r1501987 with the comment "Failed release"
> - /logging/log4j/log4j2/tags/log4j-2.0-beta8 was copied from /logging/log4j/log4j2/trunk in r1502001 (newer) with the comment "[maven-release-plugin] copy for tag log4j-2.0-beta8"
>
> ... I'm doing this like we have always done it.
>
> Nick
>
> On Feb 9, 2014, at 1:15 PM, Gary Gregory wrote:
>
>> -1
>>
>> This is still wrong. The tag should be in the format VERSION-RC#. In this case 2.0-rc1-rc2 (VERSION=2.0-rc1 and RC#=rc2). That's what we VOTE on, the tag 2.0-rc1-rc#.
>>
>> We are voting to release 2.0-rc1. The first try, 2.0-rc1-rc1, failed; now we're on to the second: 2.0-rc1-rc2.
>>
>> There must be a record of the code for the first attempt as an SVN tag, which I see in SVN, good.
>>
>> There currently is a 2.0-rc1 tag in SVN which should NOT exist until after the VOTE for a given RC passes.
>>
>> Gary
>>
>> ---------- Forwarded message ----------
>> From: <ni...@apache.org>
>> Date: Sun, Feb 9, 2014 at 2:03 PM
>> Subject: svn commit: r1566354 - /logging/log4j/log4j2/tags/log4j-2.0-rc1/
>> To: commits@logging.apache.org
>>
>>
>> Author: nickwilliams
>> Date: Sun Feb 9 19:03:23 2014
>> New Revision: 1566354
>>
>> URL: http://svn.apache.org/r1566354
>> Log:
>> [maven-release-plugin] copy for tag log4j-2.0-rc1
>>
>> Added:
>> logging/log4j/log4j2/tags/log4j-2.0-rc1/
>> - copied from r1566353, logging/log4j/log4j2/trunk/
>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1566354 - /logging/log4j/log4j2/tags/log4j-2.0-rc1/
Posted by Nick Williams <ni...@nicholaswilliams.net>.
That is not how we have done it in the past. We have never done it that way. When releasing beta8, we originally created the tag log4j-2.0-beta8. When the vote failed, we renamed that tag to log4j-2.0-beta8-rc1 and re-created the tag log4j-2.0-beta8. The vote on that tag passed. This is clearly shown in the source control log:
- /logging/log4j/log4j2/tags/log4j-2.0-beta8-rc1 was copied from /logging/log4j/log4j2/tags/log4j-2.0-beta8 in r1501987 with the comment "Failed release"
- /logging/log4j/log4j2/tags/log4j-2.0-beta8 was copied from /logging/log4j/log4j2/trunk in r1502001 (newer) with the comment "[maven-release-plugin] copy for tag log4j-2.0-beta8"
... I'm doing this like we have always done it.
Nick
On Feb 9, 2014, at 1:15 PM, Gary Gregory wrote:
> -1
>
> This is still wrong. The tag should be in the format VERSION-RC#. In this case 2.0-rc1-rc2 (VERSION=2.0-rc1 and RC#=rc2). That's what we VOTE on, the tag 2.0-rc1-rc#.
>
> We are voting to release 2.0-rc1. The first try, 2.0-rc1-rc1, failed; now we're on to the second: 2.0-rc1-rc2.
>
> There must be a record of the code for the first attempt as an SVN tag, which I see in SVN, good.
>
> There currently is a 2.0-rc1 tag in SVN which should NOT exist until after the VOTE for a given RC passes.
>
> Gary
>
> ---------- Forwarded message ----------
> From: <ni...@apache.org>
> Date: Sun, Feb 9, 2014 at 2:03 PM
> Subject: svn commit: r1566354 - /logging/log4j/log4j2/tags/log4j-2.0-rc1/
> To: commits@logging.apache.org
>
>
> Author: nickwilliams
> Date: Sun Feb 9 19:03:23 2014
> New Revision: 1566354
>
> URL: http://svn.apache.org/r1566354
> Log:
> [maven-release-plugin] copy for tag log4j-2.0-rc1
>
> Added:
> logging/log4j/log4j2/tags/log4j-2.0-rc1/
> - copied from r1566353, logging/log4j/log4j2/trunk/
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Fwd: svn commit: r1566354 - /logging/log4j/log4j2/tags/log4j-2.0-rc1/
Posted by Gary Gregory <ga...@gmail.com>.
-1
This is still wrong. The tag should be in the format VERSION-RC#. In this
case 2.0-rc1-rc2 (VERSION=2.0-rc1 and RC#=rc2). That's what we VOTE on, the
tag 2.0-rc1-rc#.
We are voting to release 2.0-rc1. The first try, 2.0-rc1-rc1, failed; now
we're on to the second: 2.0-rc1-rc2.
There must be a record of the code for the first attempt as an SVN tag,
which I see in SVN, good.
There currently is a 2.0-rc1 tag in SVN which should NOT exist until after
the VOTE for a given RC passes.
Gary
---------- Forwarded message ----------
From: <ni...@apache.org>
Date: Sun, Feb 9, 2014 at 2:03 PM
Subject: svn commit: r1566354 - /logging/log4j/log4j2/tags/log4j-2.0-rc1/
To: commits@logging.apache.org
Author: nickwilliams
Date: Sun Feb 9 19:03:23 2014
New Revision: 1566354
URL: http://svn.apache.org/r1566354
Log:
[maven-release-plugin] copy for tag log4j-2.0-rc1
Added:
logging/log4j/log4j2/tags/log4j-2.0-rc1/
- copied from r1566353, logging/log4j/log4j2/trunk/
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory