You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2024/06/03 07:59:09 UTC
Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]
DaanHoogland commented on code in PR #9138:
URL: https://github.com/apache/cloudstack/pull/9138#discussion_r1623942555
##########
ui/src/views/infra/AddPrimaryStorage.vue:
##########
@@ -870,6 +864,16 @@ export default {
params['details[0].api_password'] = values.flashArrayPassword
url = values.flashArrayURL
}
+
+ if (values.provider === 'Linstor' || params.provider === 'Linstor') {
Review Comment:
don't we by now know that params.provider has been filled?
i.e.:
```suggestion
if (params.provider === 'Linstor') {
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org