You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airavata.apache.org by sh...@apache.org on 2016/11/12 05:53:08 UTC

airavata git commit: Fixed isvalid method logic

Repository: airavata
Updated Branches:
  refs/heads/develop 6e5d1c6ee -> 3d9832699


Fixed isvalid method logic


Project: http://git-wip-us.apache.org/repos/asf/airavata/repo
Commit: http://git-wip-us.apache.org/repos/asf/airavata/commit/3d983269
Tree: http://git-wip-us.apache.org/repos/asf/airavata/tree/3d983269
Diff: http://git-wip-us.apache.org/repos/asf/airavata/diff/3d983269

Branch: refs/heads/develop
Commit: 3d983269940acd39631bcac591c6f5a7587e38da
Parents: 6e5d1c6
Author: Shameera Rathnayaka <sh...@gmail.com>
Authored: Sat Nov 12 00:52:57 2016 -0500
Committer: Shameera Rathnayaka <sh...@gmail.com>
Committed: Sat Nov 12 00:52:57 2016 -0500

----------------------------------------------------------------------
 .../apache/airavata/orchestrator/core/utils/OrchestratorUtils.java | 2 +-
 .../airavata/orchestrator/cpi/impl/SimpleOrchestratorImpl.java     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/airavata/blob/3d983269/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/core/utils/OrchestratorUtils.java
----------------------------------------------------------------------
diff --git a/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/core/utils/OrchestratorUtils.java b/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/core/utils/OrchestratorUtils.java
index 61f7188..6d32c14 100644
--- a/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/core/utils/OrchestratorUtils.java
+++ b/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/core/utils/OrchestratorUtils.java
@@ -425,6 +425,6 @@ public class OrchestratorUtils {
     }
 
     private static boolean isValid(String str) {
-        return (str != null && str.trim().isEmpty());
+        return (str != null && !str.trim().isEmpty());
     }
 }

http://git-wip-us.apache.org/repos/asf/airavata/blob/3d983269/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/cpi/impl/SimpleOrchestratorImpl.java
----------------------------------------------------------------------
diff --git a/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/cpi/impl/SimpleOrchestratorImpl.java b/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/cpi/impl/SimpleOrchestratorImpl.java
index 19a3521..a8b38dc 100644
--- a/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/cpi/impl/SimpleOrchestratorImpl.java
+++ b/modules/orchestrator/orchestrator-core/src/main/java/org/apache/airavata/orchestrator/cpi/impl/SimpleOrchestratorImpl.java
@@ -333,7 +333,7 @@ public class SimpleOrchestratorImpl extends AbstractOrchestrator{
             experimentCatalog.update(ExperimentCatalogModelType.PROCESS, processModel, processModel.getProcessId());
             return getTaskDag(taskIdList);
         } catch (Exception e) {
-            throw new OrchestratorException("Error during creating process");
+            throw new OrchestratorException("Error during creating process", e);
         }
     }