You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Francis Galiegue <fg...@gmail.com> on 2011/10/26 21:07:32 UTC
Enhancement review process?
Hello,
It has been now three weeks since I opened this enhancement request:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
I am confident enough with this patch that I actually use it instead
of the existing RemoteAddrValve (since my implementation doesn't get
confused by ::1 just to cite an example), but it has now been ten days
and I haven't had a single comment on things to improve etc. How are
enhancement requests reviewed? How long does it normally take for such
a request to be considered for inclusion?
--
Francis Galiegue, fgaliegue@gmail.com
"It seems obvious [...] that at least some 'business intelligence'
tools invest so much intelligence on the business side that they have
nothing left for generating SQL queries" (Stéphane Faroult, in "The
Art of SQL", ISBN 0-596-00894-5)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Enhancement review process?
Posted by Mark Thomas <ma...@apache.org>.
On 26/10/2011 20:42, Francis Galiegue wrote:
> On Wed, Oct 26, 2011 at 21:40, Mark Thomas <ma...@apache.org> wrote:
>
>>>
>>> + * @return <code>true</true> if a problem should trigger the
>>> failure of this
>>
>> So?
>>
>
> <code>true</true>.
Got it. Tx. I'll fix that in a sec.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Enhancement review process?
Posted by Francis Galiegue <fg...@gmail.com>.
On Wed, Oct 26, 2011 at 21:40, Mark Thomas <ma...@apache.org> wrote:
>>
>> + * @return <code>true</true> if a problem should trigger the
>> failure of this
>
> So?
>
<code>true</true>.
--
Francis Galiegue, fgaliegue@gmail.com
"It seems obvious [...] that at least some 'business intelligence'
tools invest so much intelligence on the business side that they have
nothing left for generating SQL queries" (Stéphane Faroult, in "The
Art of SQL", ISBN 0-596-00894-5)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Enhancement review process?
Posted by Mark Thomas <ma...@apache.org>.
On 26/10/2011 20:24, Francis Galiegue wrote:
> On Wed, Oct 26, 2011 at 21:17, Mark Thomas <ma...@apache.org> wrote:
>> On 26/10/2011 20:07, Francis Galiegue wrote:
>>> Hello,
>>>
>>> It has been now three weeks since I opened this enhancement request:
>>>
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
>>>
>>> I am confident enough with this patch that I actually use it instead
>>> of the existing RemoteAddrValve (since my implementation doesn't get
>>> confused by ::1 just to cite an example), but it has now been ten days
>>> and I haven't had a single comment on things to improve etc. How are
>>> enhancement requests reviewed?
>>
>> Requests are reviewed as committers have the time and interest in the
>> features being implemented.
>>
>> Your own comments on that bug seem to indicate that the patch has issues
>> with logging and exception handling. As soon as I saw that, the issue
>> went to the bottom of my todo list until the issues were fixed (or at
>> least understood).
>>
>
> Well, to the best of my efforts, I couldn't get errors to be logged at
> all, which is why I was asking for guidance... Yes, guidance. I wasn't
> trying to sound alarming or anything, I was just being honest.
>
> So, at the very least, can you tell me how to achieve that?
Right now, no. I have other stuff I am working on. Will I get around to
looking at this filter? Eventually. When will that be? I simply can't
tell you. There is a good chance one of the other committers will get
there before me.
> This is
> what I was asking, and I kind of expected "go see this and that source
> file"... I didn't know such a comment would just make me as desirable
> as the pest...
Different committers will take a different view of things. Right now I'm
not sufficiently interested in that patch to investigate why there
appears to be a problem
>> You may also want to look at my commit from earlier today regarding
>> handling of errors in security concious filters and valves.
>>
>
> Which, BTW, contains:
>
> + * @return <code>true</true> if a problem should trigger the
> failure of this
So?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Enhancement review process?
Posted by Francis Galiegue <fg...@gmail.com>.
On Wed, Oct 26, 2011 at 21:17, Mark Thomas <ma...@apache.org> wrote:
> On 26/10/2011 20:07, Francis Galiegue wrote:
>> Hello,
>>
>> It has been now three weeks since I opened this enhancement request:
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
>>
>> I am confident enough with this patch that I actually use it instead
>> of the existing RemoteAddrValve (since my implementation doesn't get
>> confused by ::1 just to cite an example), but it has now been ten days
>> and I haven't had a single comment on things to improve etc. How are
>> enhancement requests reviewed?
>
> Requests are reviewed as committers have the time and interest in the
> features being implemented.
>
> Your own comments on that bug seem to indicate that the patch has issues
> with logging and exception handling. As soon as I saw that, the issue
> went to the bottom of my todo list until the issues were fixed (or at
> least understood).
>
Well, to the best of my efforts, I couldn't get errors to be logged at
all, which is why I was asking for guidance... Yes, guidance. I wasn't
trying to sound alarming or anything, I was just being honest.
So, at the very least, can you tell me how to achieve that? This is
what I was asking, and I kind of expected "go see this and that source
file"... I didn't know such a comment would just make me as desirable
as the pest...
> You may also want to look at my commit from earlier today regarding
> handling of errors in security concious filters and valves.
>
Which, BTW, contains:
+ * @return <code>true</true> if a problem should trigger the
failure of this
;)
--
Francis Galiegue, fgaliegue@gmail.com
"It seems obvious [...] that at least some 'business intelligence'
tools invest so much intelligence on the business side that they have
nothing left for generating SQL queries" (Stéphane Faroult, in "The
Art of SQL", ISBN 0-596-00894-5)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Enhancement review process?
Posted by Mark Thomas <ma...@apache.org>.
On 26/10/2011 20:07, Francis Galiegue wrote:
> Hello,
>
> It has been now three weeks since I opened this enhancement request:
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
>
> I am confident enough with this patch that I actually use it instead
> of the existing RemoteAddrValve (since my implementation doesn't get
> confused by ::1 just to cite an example), but it has now been ten days
> and I haven't had a single comment on things to improve etc. How are
> enhancement requests reviewed?
Requests are reviewed as committers have the time and interest in the
features being implemented.
Your own comments on that bug seem to indicate that the patch has issues
with logging and exception handling. As soon as I saw that, the issue
went to the bottom of my todo list until the issues were fixed (or at
least understood).
You may also want to look at my commit from earlier today regarding
handling of errors in security concious filters and valves.
> How long does it normally take for such
> a request to be considered for inclusion?
Anywhere from less than an hour to several years.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org