You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/31 15:55:30 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #7118: fix NullPointerException with SubscriptionMode.NonDurable
315157973 opened a new pull request #7118:
URL: https://github.com/apache/pulsar/pull/7118
Fixes #7046
### Motivation
This code is to enable non-persistent subscriptions to continue to consume， based on the Id of the first message in the client's ReceiverQueue when reconnection is triggered.
But it's not considered the case that there is no messageId for the first connection. Therefore, we need to determine whether the MessageId is null.
### Modifications
### Verifying this change
unit test: NonDurableSubscriptionTest
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7118: fix NullPointerException with SubscriptionMode.NonDurable
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7118:
URL: https://github.com/apache/pulsar/pull/7118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #7118: fix NullPointerException with SubscriptionMode.NonDurable
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #7118:
URL: https://github.com/apache/pulsar/pull/7118#discussion_r433139548
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -715,11 +715,11 @@ public void connectionOpened(final ClientCnx cnx) {
}
boolean isDurable = subscriptionMode == SubscriptionMode.Durable;
- MessageIdData startMessageIdData;
+ MessageIdData startMessageIdData = null;
if (isDurable) {
// For regular durable subscriptions, the message id from where to restart will be determined by the broker.
startMessageIdData = null;
- } else {
+ } else if (startMessageId != null) {
Review comment:
Reader will use the code here, startMessageId can be obtained from Broker.
However, a judgment was added to prevent scene triggers in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7118: fix NullPointerException with SubscriptionMode.NonDurable
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7118:
URL: https://github.com/apache/pulsar/pull/7118#issuecomment-637177691
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #7118: fix NullPointerException with SubscriptionMode.NonDurable
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7118:
URL: https://github.com/apache/pulsar/pull/7118#discussion_r433073210
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -715,11 +715,11 @@ public void connectionOpened(final ClientCnx cnx) {
}
boolean isDurable = subscriptionMode == SubscriptionMode.Durable;
- MessageIdData startMessageIdData;
+ MessageIdData startMessageIdData = null;
if (isDurable) {
// For regular durable subscriptions, the message id from where to restart will be determined by the broker.
startMessageIdData = null;
- } else {
+ } else if (startMessageId != null) {
Review comment:
looks like in line 742 below, there is also a reference to `startMessageId`. Will it also throw NPE？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7118: fix NullPointerException with SubscriptionMode.NonDurable
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7118:
URL: https://github.com/apache/pulsar/pull/7118#issuecomment-636553768
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org