[jira] [Commented] (SSHD-1034) Rename org.apache.sshd.common.forward.ForwardingFilter

["Guillaume Nodet (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158673#comment-17158673 ] 

Guillaume Nodet commented on SSHD-1034:
---------------------------------------

The original class was named {{XxxForwarder}} which makes more sense, as it's the one does implement the forwarding...
It has been renamed as part of https://issues.apache.org/jira/browse/SSHD-766, where the {{Tcp}} was dropped for the better as it's not only related to {{Tcp}}, but {{Forwarder}} has been wrongly renamed to {{ForwardFilter}}.

I think we should rename {{ForwardingFilter}} back to {{Forwarder}} and same for factory and implementation.

> Rename org.apache.sshd.common.forward.ForwardingFilter
> ------------------------------------------------------
>
>                 Key: SSHD-1034
>                 URL: https://issues.apache.org/jira/browse/SSHD-1034
>             Project: MINA SSHD
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Priority: Major
>
> The name {{ForwardingFilter}} is really misleading as it contains the core implementation of the port forwarding mechanism and is not related to filtering at all (see {{TcpForwardingFilter}} which is a real filter to know if the server is allowed to listen or connect).
> The {{DefaultForwardingFilter}} and {{ForwardingFilterFactory}} should be renamed accordingly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org