You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/09 21:23:10 UTC

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5274: [HUDI-3839] Fixing incorrect selection of MT partitions to be updated

alexeykudinkin commented on code in PR #5274:
URL: https://github.com/apache/hudi/pull/5274#discussion_r846681793


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -770,18 +774,6 @@ private MetadataRecordsGenerationParams getRecordsGenerationParams() {
     }
   }
 
-  private Set<String> getMetadataPartitionsToUpdate() {

Review Comment:
   This logic is broken currently -- it will not update files partition if Column Stats is enabled.
   
   Can you elaborate on how you think it would affect Async indexing flows? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org